Spec URL: http://rdieter.fedorapeople.org/rpms/kdeedu/step.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeedu/step-4.7.0-10.fc15.src.rpm Description: Interactive Physics Simulator
For me some points to be solved before a more formal review: * typo on "Release: 10%{?dist}" for a first try :) * is it standard to use desktop-file-validate on %check ? (I use it on %build) koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3358761 Problems: + desktop-file-validate /builddir/build/BUILDROOT/step-4.7.0-10.fc16.i386/usr/share/applications/kde4/step.desktop /builddir/build/BUILDROOT/step-4.7.0-10.fc16.i386/usr/share/applications/kde4/step.desktop: error: (will be fatal in the future): value "Physics" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: Education;Science warning: File listed twice: /usr/share/doc/HTML/en/step
I personally prefer using desktop-file-* in either %install or %check. Anyway, as that is still (currently) non-fatal, let's not block the review on it (though I will poke upstream to get it fixed properly).
Spec URL: http://rdieter.fedorapeople.org/rpms/kdeedu/step.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeedu/step-4.7.1-2.fc15.src.rpm %changelog * Wed Sep 21 2011 Rex Dieter <rdieter> 4.7.1-2 - License: GPLv2+ * Sat Sep 17 2011 Rex Dieter <rdieter> 4.7.1-1 - 4.7.1
Clément, are you going to do formal review?
(In reply to comment #4) > Clément, are you going to do formal review? Feel free to take, I'm off for 3 days.
Name: ok License: ok Source: ok BRs/Reqs: ok Macros used consistently: ok ldconfig: NA Desktop file validations: ok Locales: ok Docs: ok Devel: NA Files: ok Build: ok rpmlint: no need to fix step.x86_64: E: script-without-shebang /usr/share/applications/kde4/step.desktop step.x86_64: W: no-manual-page-for-binary step No issues found, setting fedora-review+.
New Package SCM Request ======================= Package Name: step Short Description: Interactive Physics Simulator Owners: than jreznik ltinkl rnovacek rdieter kkofler Branches: f16
Git done (by process-git-requests).
imported