Bug 736051 - Review Request: rubygem-archivist - A rails 3 model archiving system based on acts_as_archive
Summary: Review Request: rubygem-archivist - A rails 3 model archiving system based on...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Marek Mahut
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-09-06 14:21 UTC by Maros Zatko
Modified: 2013-10-19 14:42 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-14 12:49:25 UTC
mfojtik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Maros Zatko 2011-09-06 14:21:49 UTC
Spec URL: http://v3.sk/~hexo/rpm/rubygem-archivist.spec
SRPM URL: http://v3.sk/~hexo/rpm/rubygem-archivist-1.0.5.1-1.fc15.src.rpm
Description: This is a functional replacement for acts_as_archive in
rails 3 applications, the only functionality that is not
duplicated is the migration from acts_as_paranoid

This is my first package and I need sponsor.

Comment 1 Gregor Tätzner 2011-09-06 22:42:08 UTC
unofficial feedback:
rpmlint rubygem-archivist-1.0.5.1-1.fc15.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint rubygem-archivist-1.0.5.1-1.fc15.noarch.rpm 
rubygem-archivist.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Are you sure --no-rdoc and --no-ri in gem install is right?

otherwise it looks good.

Comment 2 Michal Fojtik 2011-09-13 12:03:50 UTC
Review:

<snip>
Requires: ruby(abi) = %{rubyabi}
.... 
Requires: ruby 
</snip>

* Is this necessary?
* Is the %prep section necessary? I can't see any tests running there. In %prep you copy all gem files with gem install in one place and in %install you move them to another. Why not use gem install in %install section?
* Remove the 'echo %{SOURCE0}'
* Is the rubygem(shoulda) really needed as a Runtime dependency?

Comment 3 Maros Zatko 2011-09-13 14:14:04 UTC
removed:
requirement of ruby and shoulda,
'echo %{SOURCE0}'

added:
%doc section
ri and rdocs are now part of package

Spec URL: http://v3.sk/~hexo/rpm/rubygem-archivist.spec
SRPM URL: http://v3.sk/~hexo/rpm/rubygem-archivist-1.0.5.1-2.fc15.src.rpm

Comment 4 Michal Fojtik 2011-09-14 11:22:53 UTC
Looks safe. Suggestion: Move %doc to -doc subpackage :)

REVIEW+

Comment 5 Marek Mahut 2011-09-14 11:29:46 UTC
Taking for sponsorship.

Comment 6 Maros Zatko 2011-09-14 11:52:27 UTC
New Package SCM Request
=======================
Package Name: rubygem-archivist
Short Description: A rails 3 model archiving system based on acts_as_archive
Owners: mzatko
Branches: f15
InitialCC:

Comment 7 Marek Mahut 2011-09-14 12:32:58 UTC
I don't think you can set up you as the owner, we can change the ownership after you get sponsored.

New Package SCM Request
=======================
Package Name: rubygem-archivist
Short Description: A rails 3 model archiving system based on acts_as_archive
Owners: mmahut
Branches: f15 f16
InitialCC: mzatko

Comment 8 Gwyn Ciesla 2011-09-14 12:38:58 UTC
Git done (by process-git-requests).

Comment 9 Marek Mahut 2011-09-14 12:49:25 UTC
Thank you, building it now.

Comment 10 Fedora Update System 2011-09-14 13:03:49 UTC
rubygem-archivist-1.0.5.1-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/rubygem-archivist-1.0.5.1-2.fc15

Comment 11 Fedora Update System 2011-09-16 01:57:16 UTC
rubygem-archivist-1.0.5.1-2.fc15 has been pushed to the Fedora 15 stable repository.

Comment 12 Vít Ondruch 2011-09-21 06:02:11 UTC
(In reply to comment #2)
> Review:
> 
> <snip>
> Requires: ruby(abi) = %{rubyabi}
> .... 
> Requires: ruby 
> </snip>
> 
> * Is this necessary?
> * Is the %prep section necessary? I can't see any tests running there. In %prep
> you copy all gem files with gem install in one place and in %install you move
> them to another. Why not use gem install in %install section?
> * Remove the 'echo %{SOURCE0}'
> * Is the rubygem(shoulda) really needed as a Runtime dependency?

Don't that forget we have JRuby in Fedora now. If JRuby are going to provide ruby(abi) (and they should if they are not doing so yet), the it makes sense. However this is unfortunately gray area yet :/

Comment 13 Vít Ondruch 2012-08-10 13:08:20 UTC
Package Change Request
======================
Package Name: rubygem-archivist
New Branches: f18
Owners: vondruch jzigmund mmahut
InitialCC:

Comment 14 Gwyn Ciesla 2012-08-10 13:09:55 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.