Bug 736537 - aisleriot - A collection of card games
Summary: aisleriot - A collection of card games
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2011-09-08 00:32 UTC by Matthias Clasen
Modified: 2011-09-12 16:41 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-09-12 16:41:45 UTC
Type: ---
michel: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Matthias Clasen 2011-09-08 00:32:47 UTC
aisleriot used to be part of gnome-games, but has recently become a standalone module.

Spec URL: http://mclasen.fedorapeople.org/aisleriot.spec
SRPM URL: http://mclasen.fedorapeople.org/aisleriot-3.1.1-1.fc16.src.rpm
AisleRiot is a collection of over 80 card games programmed in scheme.

Comment 1 Michel Lind 2011-09-08 12:46:56 UTC
Almost ready; just a couple of minor issues regarding scriptlets and desktop file validation

* TODO Review [75%]
  - [X] Names [2/2]
    - [X] Package name
    - [X] Spec name
  - [X] Package version [2/2]
    - [X] Version number
    - [X] Release tag
  - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
  - [X] Source files match upstream
        $ sha1sum ./aisleriot-3.1.1.tar.xz ../SOURCES/aisleriot-3.1.1.tar.xz 
        e9a436e4c5b70985ca09808773dbb0d6c6674c2f  ./aisleriot-3.1.1.tar.xz
        e9a436e4c5b70985ca09808773dbb0d6c6674c2f  ../SOURCES/aisleriot-3.1.1.tar.xz
  - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]]
  - [X] License [4/4]
    - [X] License is Fedora-approved
    - [X] No licensing conflict
    - [X] License field accurate
    - [X] License included iff packaged by upstream
  - [-] rpmlint [1/2]
    - [X] on src.rpm
          $ rpmlint SRPMS/aisleriot-3.1.1-1.fc16.src.rpm 
          1 packages and 0 specfiles checked; 0 errors, 0 warnings.
    - [ ] on x86_64.rpm
          $ rpmlint ./aisleriot-*
aisleriot.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/aisleriot.schemas
aisleriot.x86_64: E: incorrect-fsf-address /usr/share/doc/aisleriot-3.1.1/COPYING-DOCS
aisleriot.x86_64: W: dangerous-command-in-%pre rm
aisleriot.x86_64: W: dangerous-command-in-%post rm
aisleriot-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aisleriot-3.1.1/src/ar-stock.h
aisleriot-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aisleriot-3.1.1/src/ar-stock.c
aisleriot-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aisleriot-3.1.1/src/smclient/eggdesktopfile.h
aisleriot-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aisleriot-3.1.1/src/smclient/eggdesktopfile.c
aisleriot-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aisleriot-3.1.1/src/lib/ar-sound.h
aisleriot-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/aisleriot-3.1.1/src/lib/ar-sound.c
2 packages and 0 specfiles checked; 7 errors, 3 warnings.
         non-conffile: this should be fixed; mark as %conf{noreplace} ?
         dangerous command: ignore; part of gconf macros
         FSF address: probably could be reported upstream

  - [X] Language & locale [3/3]
    - [X] Spec in US English
    - [X] Spec legible
    - [X] Use %find_lang to handle locale files
  - [X] Build [3/3]
    - [X] Koji results
    - [X] BRs complete
    - [X] Directory ownership
  - [X] Spec inspection [6/6]
    - [X] No duplicate files
    - [X] File permissions
    - [X] Filenames must be UTF-8
    - [X] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting RHEL5]])
    - [X] Macro usage consistent
    - [X] Documentation [1/1]
      - [X] %doc files are non-essential
  - [ ] Desktop file validation
        desktop files not validated; please use desktop-file-validate
  - [-] [[http://fedoraproject.org/wiki/Packaging/ScriptletSnippets][Scriptlets]] [1/3]
    - [ ] desktop-database (desktop entry has MimeType)
          desktop entries have no MimeType so update-desktop-database should
          be removed (also, their outputs are not silenced)
    - [ ] GSettings schema
          output needs to be silenced by redirecting to null; and
          in postun, needs to be or-ed to silence failures if
          glib-compile-schemas is not installed:
    - [X] icon cache (icons in %{_datadir}/icons/)

Comment 2 Matthias Clasen 2011-09-08 18:15:36 UTC
Spec URL: http://mclasen.fedorapeople.org/aisleriot.spec
SRPM URL: http://mclasen.fedorapeople.org/aisleriot-3.1.1-2.fc16.src.rpm

I've done all the things you've mentioned except for the %conf change - if you look around, you'll find that we don't ship gconf schemas as %conf files anywhere. They are simply misplaced in /etc, historical accident that will be fixed by dconf.

Comment 3 Michel Lind 2011-09-10 08:02:09 UTC

the new spec and SRPM don't seem to have been uploaded. Could you do that so I can take a look?


Comment 4 Matthias Clasen 2011-09-10 19:49:32 UTC
oh, sorry. should be there now.

Comment 5 Michel Lind 2011-09-11 11:42:52 UTC
Thanks! Everything looks fine - APPROVED

Comment 6 Matthias Clasen 2011-09-12 12:57:16 UTC
New Package SCM Request
Package Name: aisleriot 
Short Description: A collection of card games
Owners: mclasen, rstrode
Branches: f16

Comment 7 Gwyn Ciesla 2011-09-12 14:06:05 UTC
Git done (by process-git-requests).

Please correctly format the bug summary in the future.  Thanks!

Comment 8 Matthias Clasen 2011-09-12 16:41:45 UTC
builds done

Note You need to log in before you can comment on or make changes to this bug.