Bug 738678 - subscription-manager facts --update will override virt.guests made by virt-who
subscription-manager facts --update will override virt.guests made by virt-who
Product: Candlepin
Classification: Community
Component: candlepin (Show other bugs)
Unspecified Unspecified
unspecified Severity high
: ---
: ---
Assigned To: Michael Stead
John Sefler
Depends On:
Blocks: rhsm-rhel62
  Show dependency treegraph
Reported: 2011-09-15 10:12 EDT by Keqin Hong
Modified: 2015-05-14 11:31 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2011-10-09 07:36:08 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Keqin Hong 2011-09-15 10:12:19 EDT
Description of problem:
Current facts collected by virt-who doesn't include virt.guests. As such, subscription-manager facts --update will override virt.guests fact in candlepin posted by virt-who.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Open debug for virt-who and enable daemon env var 
2. service virt-who start
3. subscription-manager facts --update 
4. run virt-who again
Actual results:
after step 4, you will virt-who see virt.guests fact have been changed in candlepin. As a result, it will add virt.guests fact and post facts again to candlepin.

Expected results:
sub-man facts --update should override what virt.guests fact virt-who added

Additional info:
virt-who will not update facts to candlepin if it sees no changes in virt.guests fact.
Comment 1 Keqin Hong 2011-09-15 10:15:56 EDT
>Expected results:
>sub-man facts --update should override what virt.guests fact virt-who added
sorry, should be
sub-man facts --update should NOT override virt.guests fact virt-who added
Comment 2 Michael Stead 2011-09-27 10:39:15 EDT
This should be addressed by the fix for 737935, once virt-who is modified to use the new API.

Leaving it as ASSIGNED until virt-who update is done. I'll verify once this happens and move to MODIFIED.
Comment 3 Michael Stead 2011-10-05 15:27:11 EDT
Since virt-who no longer updates consumer facts, and instead stores them on the consumer; this bug is no longer an issue.
Comment 5 Michael Stead 2011-10-08 12:35:03 EDT
When this bug was submitted, virt-who would send the list of guestId to candlepin, and candlepin would store them in a fact named virt.guests.

This logic has changed as of virt-who commit:

Since virt-who is no longer updating facts, no overwrite happens.

The new logic is as follows:

Once candlepin receives the list of guest IDs from virt-who, it now stores them on the consumer as guestIds in a seperate database table (cp_consumer_guests), and will appear in the consumer's JSON as guestIds.
Comment 6 Keqin Hong 2011-10-09 07:36:08 EDT
Following the new design, this bug no longer exist.

Note You need to log in before you can comment on or make changes to this bug.