Created attachment 523585 [details]
See attached (applies on the top of the current Rawhide build). I don't think we need to require bea-stax-api which is now part of OpenJDK.
And now, we don't have to use perl, when we have sed ;)
Only comment is about building with no-xmlbean. Why?
Other than that it looks good.
This is the explanation I've got on #ringojs channel:
<earl> mcepl: you can just compile with no-xmlbeans=1 to skip the old xmlbeans stuff
<mcepl> earl: and what would it do?
<earl> it won't build the legacy e4x impl
<mcepl> legacy? So, what it would build? no E4X?
<earl> the new non-xmlbeans-based e4x impl
<earl> ant jar -Dno-xmlbeans=1
<earl> (or set this in a custom build.local.properties)
<mcepl> it's easier to do it with a parameter in spec file
I was also pointed to https://github.com/mozilla/rhino/blob/master/xmlimplsrc/build.xml#L38-41
"no-xmlbeans: Will cause the old, XMLBeans-based implementation of E4X not to be built"
Should this be closed as duplicate of bug 739211 ?
No, each patch deals with a different issue. Of course, I have patches for both.
Created attachment 524106 [details]
rebased patch on top of rhino-1.7R3-1
Created attachment 524108 [details]
rebased patch on top of rhino-1.7R3-1 (and also bump the release)
Looks perfect. Please apply.
rhino-1.7R3-2.fc16 has been submitted as an update for Fedora 16.
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing rhino-1.7R3-2.fc16'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
rhino-1.7R3-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.