Bug 7399 – %if construct doesn't parse macro names correctly

Bugzilla will be upgraded to version 5.0 on a still to be determined date in the near future. The original upgrade date has been delayed.

Bug 7399 - %if construct doesn't parse macro names correctly

Summary:	%if construct doesn't parse macro names correctly

Status:	CLOSED RAWHIDE

Aliases:	None

Product:	Red Hat Linux
Classification:	Retired
Component:	rpm (Show other bugs)
Sub Component:
Version:	4.2
Hardware:	All Linux

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Jeff Johnson
QA Contact:
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	1999-11-28 16:02 EST by yates
Modified:	2008-05-01 11:37 EDT (History)
CC List:	0 users

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	1999-11-29 09:17:51 EST
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description yates 1999-11-28 16:02:09 EST

The %if construct doesn't recognize "_" as a legas first character in a
macro name.  For example
	%define _foo bar
	...
	%if _foo == "bar"
	...
gets an error, wheras
	%define foo bar
	...
	%if foo == "bar"
	...
does not.

Suggest changing line 265 in expression.c
	    } else if (isalpha(*p)) {
to
	    } else if (isalpha(*p) || *p == '_') {

Comment 1 Jeff Johnson 1999-11-29 09:17:59 EST

This had been fixed in (at least) rpm-3.0.4. Thanks for the patch.

Note You need to log in before you can comment on or make changes to this bug.