Red Hat Bugzilla – Bug 740062
fcoe.py fails to detect FCoE NIC due to extraneous newline character
Last modified: 2014-09-30 19:40:32 EDT
Created attachment 524089 [details]
Patch against current anaconda master branch
Description of problem:
When installing to an FCoE target, anaconda does not automatically identify the FCoE NIC based upon the EDD information. The problem is a trivial mistake in fcoe.py, fixed by the following patch (attached in full):
- (key, val) = rc.split("=", 1)
+ (key, val) = rc.strip().split("=", 1)
Without the patch, fcoe.py ends up using "ethX\n" as the interface name instead of "ethX", and so ends up reporting an error "Unknown FCoE NIC found in EDD".
The attached patch has been tested and verified to work.
Version-Release number of selected component (if applicable):
Problem is still present in anaconda git tree master branch at the time of writing.
Steps to Reproduce:
1. Begin an installation to an FCoE target using FCoE-capable BIOS boot firmware such as iPXE.
2. After clicking on "Specialized Storage Devices", switch to console Ctrl-Alt-F3 and observe the error message:
Unknown FCoE NIC found in EDD: eth0
(note the unexpected extra newline in the middle of the message).
3. Observe that the FCoE initiator has not been created for the NIC, and hence the FCoE target disks are not visible within the installer.
Installation to an FCoE target is not possible without manually enabling the FCoE initiator via "Add Advanced Target".
The FCoE NIC should be identified automatically based upon the EDD information, with no need to ever click on "Add Advanced Target".
The attached one-line patch has been tested and verified to fix the problem.
This looks like a reasonable patch to me. Ales - you've touched fcoe.py the most, so why don't you look over it and if you like it, apply to master. Thanks.
yes, this looks reasonable. we apparently haven't discovered it because few people use fcoe in fedora and in rhel they use the GUI.
Patch proposed for a review:
I will push this to f16 only after it is accepted as a blocker.
Discussed in the 2011-09-30 blocker bug review meeting. Accepted as a Fedora 16 final blocker as it violates the following final release criterion :
The installer must be able to complete an installation using any network-attached storage devices (e.g. iSCSI, FCoE, Fibre Channel).
Fixed by 827abd4515ee5517d6eea902e1e78cca99984d93 (0fd9bd19f45612456e771c437ca348804c05770b on master).
Michael, thank you for the fix.
Discussed at 2011-10-14 blocker review meeting. Michael, the fix for this should be in Fedora 16 Final TC1 which will land soon, please re-test and confirm with that. I'll update the bug again when it's available. Thanks!
TC2 is available with the fix:
can you please test it and confirm that it's fixed? Thanks!
Fix is also in TC3:
we really need confirmation that this is fixed, but if we don't get any, we'll have to proceed with release on the assumption that it is.
anaconda 16.24-2 (glibc rebuild) went stable, so CLOSING. Could still do with verification of the fix in TC3 or pending RC1.
Fedora Bugzappers volunteer triage team