Bug 740422 - broken postinstall and postuninstall scriptlets in selinux-policy and selinux-policy-targeted
Summary: broken postinstall and postuninstall scriptlets in selinux-policy and selinux...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: selinux-policy
Version: 16
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Miroslav Grepl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-09-22 01:34 UTC by Andre Robatino
Modified: 2011-09-22 12:30 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-09-22 08:21:24 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Andre Robatino 2011-09-22 01:34:05 UTC 
Description of problem:
In selinux-policy-3.10.0-32.fc16.noarch's postuninstall scriptlet:

if [ $1 = 0 ]; then

In selinux-policy-targeted-3.10.0-32.fc16.noarch's postinstall scriptlet:

if [ $? = 0  -a "${SELINUXTYPE}" = targeted -a -f ${FILE_CONTEXT}.pre ]; then

Version-Release number of selected component (if applicable):
selinux-policy-3.10.0-32.fc16.noarch
Comment 1 Andre Robatino 2011-09-22 02:11:34 UTC 
Same problem in selinux-policy-3.10.0-31.fc17.noarch and selinux-policy-targeted-3.10.0-31.fc17.noarch in Rawhide.
Comment 2 Andre Robatino 2011-09-22 02:24:01 UTC 
Actually, I'm not sure this is a bug anymore (bash syntax isn't the same as C regarding the use of the = sign, it appears to be legitimate when doing string comparisons). Can someone check if this is a bug?
Comment 3 Andre Robatino 2011-09-22 02:38:49 UTC 
Looking more like a false alarm as the same syntax occurs in F15's selinux-policy* packages. But I'll wait for someone to confirm before closing.
Comment 4 Miroslav Grepl 2011-09-22 08:21:24 UTC 
Yes, this is ok. Closing this bug.
Comment 5 Daniel Walsh 2011-09-22 12:30:00 UTC 
This is the equivalent of doing the test command

man test 
...
       STRING1 = STRING2
              the strings are equal
Note You need to log in before you can comment on or make changes to this bug.