Bug 741433 (libpgf) - Review Request: libpgf - PGF (Progressive Graphics File) library
Summary: Review Request: libpgf - PGF (Progressive Graphics File) library
Keywords:
Status: CLOSED ERRATA
Alias: libpgf
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-09-26 19:53 UTC by nucleo
Modified: 2015-06-30 21:49 UTC (History)
5 users (show)

Fixed In Version: libpgf-6.11.24-1.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-10-04 21:13:02 UTC
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description nucleo 2011-09-26 19:53:02 UTC
Spec URL:
http://nucleo.fedorapeople.org/pkg-reviews/libpgf/libpgf.spec
SRPM URL:
http://nucleo.fedorapeople.org/pkg-reviews/libpgf/libpgf-6.11.24-1.fc17.src.rpm
Description:
libPGF contains an implementation of the Progressive Graphics File (PGF)
which is a new image file format, that is based on a discrete, fast
wavelet transform with progressive coding features. PGF can be used
for lossless and lossy compression.

Comment 1 nucleo 2011-09-26 19:54:53 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3379566

rpmlint output:
$ rpmlint libpgf-6.11.24-1.fc17.src.rpm libpgf-6.11.24-1.fc17.i686.rpm libpgf-devel-6.11.24-1.fc17.i686.rpm libpgf-debuginfo-6.11.24-1.fc17.i686.rpm libpgf-6.11.24-1.fc17.x86_64.rpm libpgf-devel-6.11.24-1.fc17.x86_64.rpm libpgf-debuginfo-6.11.24-1.fc17.x86_64.rpm
libpgf.src: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless
libpgf.src: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy
libpgf.i686: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless
libpgf.i686: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy
libpgf.i686: E: incorrect-fsf-address /usr/share/doc/libpgf-6.11.24/README
libpgf-devel.i686: W: no-documentation
libpgf-devel.i686: E: incorrect-fsf-address /usr/include/libpgf/PGFtypes.h
libpgf-devel.i686: E: incorrect-fsf-address /usr/include/libpgf/PGFplatform.h
libpgf-devel.i686: E: incorrect-fsf-address /usr/include/libpgf/PGFstream.h
libpgf-devel.i686: E: incorrect-fsf-address /usr/include/libpgf/PGFimage.h
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/include/PGFtypes.h
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Decoder.cpp
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/BitStream.h
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Decoder.h
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/WaveletTransform.h
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/WaveletTransform.cpp
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/include/PGFstream.h
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/include/PGFplatform.h
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Subband.h
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Subband.cpp
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/PGFimage.cpp
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Encoder.h
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Encoder.cpp
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/src/PGFstream.cpp
libpgf-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/libpgf/include/PGFimage.h
libpgf.x86_64: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless
libpgf.x86_64: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy
libpgf.x86_64: E: incorrect-fsf-address /usr/share/doc/libpgf-6.11.24/README
libpgf-devel.x86_64: W: no-documentation
libpgf-devel.x86_64: E: incorrect-fsf-address /usr/include/libpgf/PGFtypes.h
libpgf-devel.x86_64: E: incorrect-fsf-address /usr/include/libpgf/PGFplatform.h
libpgf-devel.x86_64: E: incorrect-fsf-address /usr/include/libpgf/PGFstream.h
libpgf-devel.x86_64: E: incorrect-fsf-address /usr/include/libpgf/PGFimage.h
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/include/PGFtypes.h
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Decoder.cpp
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/BitStream.h
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Decoder.h
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/include/PGFstream.h
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/WaveletTransform.h
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/WaveletTransform.cpp
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/include/PGFplatform.h
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Subband.h
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/PGFstream.cpp
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Subband.cpp
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/PGFimage.cpp
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Encoder.h
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/src/Encoder.cpp
libpgf-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/libpgf/include/PGFimage.h
7 packages and 0 specfiles checked; 40 errors, 8 warnings.

Comment 2 Rex Dieter 2011-09-26 20:35:28 UTC
naming : OK

license: OK

sources: OK
md5sum *.zip
ba197ba886664a9b6f7b9757f5a2fb42  libpgf-6.11.24-src.zip

scriptlets: OK

macros: OK


SHOULD: Add BuildRequires: doxygen
and you'll get some more devel docs (to include in -devel), but that can be done post-review.

Otherwise, simple library, APPROVED.

Comment 3 nucleo 2011-09-26 21:13:11 UTC
Added BuildRequires: doxygen
Patched doc/Makefile.am to not install docs in /usr/share/doc,
html docs installed in %doc instead.

http://nucleo.fedorapeople.org/pkg-reviews/libpgf/libpgf.spec

http://nucleo.fedorapeople.org/pkg-reviews/libpgf/libpgf-6.11.24-1.fc15.src.rpm

Thanks.

Comment 4 nucleo 2011-09-26 21:21:07 UTC
New Package SCM Request
=======================
Package Name: libpgf
Short Description: PGF (Progressive Graphics File) library
Owners: rdieter nucleo
Branches: f15 f16
InitialCC:

Comment 5 Gwyn Ciesla 2011-09-26 22:48:08 UTC
Git done (by process-git-requests).

rdieter, please take ownership of Review BZs.  Thanks!

Comment 6 Kevin Kofler 2011-09-26 23:01:02 UTC
I searched all of Bugzilla and found only 2 instances where he forgot that (the other one was bug 220635 from 4.5 years ago), so I think he knows the procedure. :-)

I just reassigned the 2 affected bugs.

Now if this is an automated complaint by the script, why can't it reassign the bug by itself instead of complaining?

Comment 7 Fedora Update System 2011-09-27 01:02:42 UTC
libpgf-6.11.24-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/libpgf-6.11.24-1.fc16

Comment 8 Fedora Update System 2011-09-27 01:03:01 UTC
libpgf-6.11.24-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/libpgf-6.11.24-1.fc15

Comment 9 Fedora Update System 2011-09-27 17:32:01 UTC
libpgf-6.11.24-1.fc16 has been pushed to the Fedora 16 testing repository.

Comment 10 Fedora Update System 2011-10-04 21:12:52 UTC
libpgf-6.11.24-1.fc16, digikam-2.1.1-5.fc16 has been pushed to the Fedora 16 stable repository.

Comment 11 Fedora Update System 2011-10-08 18:01:13 UTC
libpgf-6.11.24-1.fc15 has been pushed to the Fedora 15 stable repository.

Comment 12 pcheng 2015-06-30 21:30:58 UTC
Is this libpgf still being maintained for security bugs?

Comment 13 nucleo 2015-06-30 21:49:52 UTC
(In reply to pcheng from comment #12)
> Is this libpgf still being maintained for security bugs?

I didn't see any bugs filed for libpgf.


Note You need to log in before you can comment on or make changes to this bug.