RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 741510 - Aligning issue with snapshot XML description
Summary: Aligning issue with snapshot XML description
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.2
Hardware: Unspecified
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Eric Blake
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-09-27 05:57 UTC by Nan Zhang
Modified: 2012-06-20 06:31 UTC (History)
9 users (show)

Fixed In Version: libvirt-0.9.9-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-20 06:31:51 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0748 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2012-06-19 19:31:38 UTC

Description Nan Zhang 2011-09-27 05:57:56 UTC 
Description of problem:
domain XML has aligning issue in snapshot XML output, that should be indent.

<domainsnapshot>
  <name>s1</name>
  <state>running</state>
  <creationTime>1265418156</creationTime>
<domain type='kvm'>
  <name>rhel6</name>
  <uuid>5bf39f9a-4845-5116-d339-00e924e50551</uuid>
  <memory>524288</memory>
...
...
</domain>
</domainsnapshot>

Version-Release number of selected component (if applicable):
libvirt-0.9.4-13.el6.x86_64

How reproducible:
always

Steps to Reproduce:
# virsh snapshot-list rhel6
 Name                 Creation Time             State
------------------------------------------------------------
 s1                   2010-02-05 20:02:36 -0500 running

# virsh snapshot-dumpxml rhel6 s1
  
Actual results:
<domainsnapshot>
  ...
<domain>
  ...
</domain>
</domainsnapshot>

Expected results:
<domainsnapshot>
  ...
  <domain>
    ...
  </domain>
</domainsnapshot>

Additional info:
Comment 2 Eric Blake 2011-09-27 12:03:43 UTC 
This is cosmetic.  Although I have a v1 upstream series proposed (and am working on v2 to address the comments raised), I do not think that backporting 14 patches for a cosemetic-only reason is appropriate this late in RHEL 6.2 development.  I'd prefer to defer this to 6.3.

https://www.redhat.com/archives/libvir-list/2011-September/msg00916.html
Comment 3 Dave Allan 2011-09-27 20:20:05 UTC 
(In reply to comment #2)
> This is cosmetic.  Although I have a v1 upstream series proposed (and am
> working on v2 to address the comments raised), I do not think that backporting
> 14 patches for a cosemetic-only reason is appropriate this late in RHEL 6.2
> development.  I'd prefer to defer this to 6.3.
> 
> https://www.redhat.com/archives/libvir-list/2011-September/msg00916.html

Agreed.
Comment 4 Eric Blake 2011-09-29 16:30:56 UTC 
For the record, v2 of the series is here:
https://www.redhat.com/archives/libvir-list/2011-September/msg01254.html
Comment 6 Eric Blake 2011-11-23 20:53:59 UTC 
commit 9cba3927684f7fe46872fae74843087139a4cca2
Author: Eric Blake <eblake>
Date:   Sat Sep 17 06:57:30 2011 -0600

    snapshot: indent domain xml when nesting
    
    <domainsnapshot> is the first public instance of <domain> being
    used as a sub-element, although we have two other private uses
    (runtime state, and migration cookie).  Although indentation has
    no effect on XML parsing, using it makes the output more consistent.
    
    This uses virBuffer auto-indentation to obtain the effect, for all
    but the portions of <domain> that are not generated a line at a
    time into the same virBuffer.  Further patches will clean up the
    remaining problems.
Comment 8 zhpeng 2012-01-10 03:24:40 UTC 
Test it with:
libvirt-0.9.9-1.el6.x86_64

And the xml is the respected result.

<domainsnapshot>
  ...
  <domain type='kvm'>
  ...
  </domain>
</domainsnapshot>
Comment 11 errata-xmlrpc 2012-06-20 06:31:51 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html
Note You need to log in before you can comment on or make changes to this bug.