Bug 742476 – Make eject fail for non-removable drives even with -f

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 742476 - Make eject fail for non-removable drives even with -f

Summary:	Make eject fail for non-removable drives even with -f

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	qemu-kvm (Show other bugs)
Sub Component:
Version:	6.2
Hardware:	Unspecified Unspecified

Priority	medium Severity medium
Target Milestone:	rc
Target Release:	---
Assigned To:	Markus Armbruster
QA Contact:	Virtualization Bugs
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:	742458 748554
	Show dependency tree / graph

Reported:	2011-09-30 05:33 EDT by juzhang
Modified:	2013-01-09 19:24 EST (History)
CC List:	6 users (show)

See Also:
Fixed In Version:	qemu-kvm-0.12.1.2-2.206.el6
Doc Type:	Bug Fix
Doc Text:	Cause: Monitor command eject -f worked even for non-removable drives Consequence: Unwise eject -f of non-removable drive made the drive unusable for guest (looks like bad hardware failure) Fix: Refuse to eject non-removable drive Result: User needs to be more creative to screw up his guest.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2011-12-06 11:04:45 EST
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2011:1531	normal	SHIPPED_LIVE	Moderate: qemu-kvm security, bug fix, and enhancement update	2011-12-05 20:23:30 EST

Groups: None (edit)

Description juzhang 2011-09-30 05:33:02 EDT

Description of problem:
You could eject -f non-removable drives, such as hard disks.hard disk should be removed via device_del.


Version-Release number of selected component (if applicable):
qemu-kvm-0.12.1.2-2.192.el6.x86_64
guest kernel
#uname -r
2.6.32-195.el6.x86_64


How reproducible:
100%

Steps to Reproduce:
1.boot guest
2.(qemu) info block
drive-virtio0-0-0: type=hd removable=0 file=/home/timerdevice/rhel62-guest-new.qcow2 ro=0 drv=qcow2 encrypted=0
3.(qemu) info status 
VM status: running
(qemu) block I/O error in device 'drive-virtio0-0-0': Input/output error (5)
block I/O error in device 'drive-virtio0-0-0': Input/output error (5)
block I/O error in device 'drive-virtio0-0-0': Input/output error (5)

  
Actual results:
After step3,disk is rejected.

Expected results:
should not be eject successful 

Additional info:

Comment 1 juzhang 2011-09-30 05:34:10 EDT

http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-September/msg00677.html

According to our test results. 
with this patch fix this issue.add this issue into tracker bug(bz742458)

Comment 2 Dor Laor 2011-10-02 10:45:50 EDT

It might be fixed with the above series in 6.2 but I'll move it to 6.3 just in case

Comment 3 Markus Armbruster 2011-10-04 03:39:58 EDT

Moving back to 6.2, because I want all the prerequisites for tracker bug 742458 there.

Comment 9 juzhang 2011-10-20 05:38:44 EDT

Verified with qemu-kvm-0.12.1.2-2.199.el6,the steps are as same as comment0

Results:
(qemu) eject -f drive-virtio-disk0
Device 'drive-virtio-disk0' is not removable

Comment 13 Eduardo Habkost 2011-10-28 14:00:31 EDT

Moving to ON_QA because Errata Tool did not do it

Comment 15 Markus Armbruster 2011-11-18 05:00:13 EST

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause: Monitor command eject -f worked even for non-removable drives
Consequence: Unwise eject -f of non-removable drive made the drive unusable for guest (looks like bad hardware failure)
Fix: Refuse to eject non-removable drive
Result: User needs to be more creative to screw up his guest.

Comment 16 errata-xmlrpc 2011-12-06 11:04:45 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1531.html

Note You need to log in before you can comment on or make changes to this bug.