Bug 742476 - Make eject fail for non-removable drives even with -f
Summary: Make eject fail for non-removable drives even with -f
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: qemu-kvm
Version: 6.2
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Markus Armbruster
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 742458 748554
TreeView+ depends on / blocked
 
Reported: 2011-09-30 09:33 UTC by juzhang
Modified: 2013-01-10 00:24 UTC (History)
6 users (show)

Fixed In Version: qemu-kvm-0.12.1.2-2.206.el6
Doc Type: Bug Fix
Doc Text:
Cause: Monitor command eject -f worked even for non-removable drives Consequence: Unwise eject -f of non-removable drive made the drive unusable for guest (looks like bad hardware failure) Fix: Refuse to eject non-removable drive Result: User needs to be more creative to screw up his guest.
Clone Of:
Environment:
Last Closed: 2011-12-06 16:04:45 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:1531 0 normal SHIPPED_LIVE Moderate: qemu-kvm security, bug fix, and enhancement update 2011-12-06 01:23:30 UTC

Description juzhang 2011-09-30 09:33:02 UTC 
Description of problem:
You could eject -f non-removable drives, such as hard disks.hard disk should be removed via device_del.


Version-Release number of selected component (if applicable):
qemu-kvm-0.12.1.2-2.192.el6.x86_64
guest kernel
#uname -r
2.6.32-195.el6.x86_64


How reproducible:
100%

Steps to Reproduce:
1.boot guest
2.(qemu) info block
drive-virtio0-0-0: type=hd removable=0 file=/home/timerdevice/rhel62-guest-new.qcow2 ro=0 drv=qcow2 encrypted=0
3.(qemu) info status 
VM status: running
(qemu) block I/O error in device 'drive-virtio0-0-0': Input/output error (5)
block I/O error in device 'drive-virtio0-0-0': Input/output error (5)
block I/O error in device 'drive-virtio0-0-0': Input/output error (5)

  
Actual results:
After step3,disk is rejected.

Expected results:
should not be eject successful 

Additional info:
Comment 1 juzhang 2011-09-30 09:34:10 UTC 
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-September/msg00677.html

According to our test results. 
with this patch fix this issue.add this issue into tracker bug(bz742458)
Comment 2 Dor Laor 2011-10-02 14:45:50 UTC 
It might be fixed with the above series in 6.2 but I'll move it to 6.3 just in case
Comment 3 Markus Armbruster 2011-10-04 07:39:58 UTC 
Moving back to 6.2, because I want all the prerequisites for tracker bug 742458 there.
Comment 9 juzhang 2011-10-20 09:38:44 UTC 
Verified with qemu-kvm-0.12.1.2-2.199.el6,the steps are as same as comment0

Results:
(qemu) eject -f drive-virtio-disk0
Device 'drive-virtio-disk0' is not removable
Comment 13 Eduardo Habkost 2011-10-28 18:00:31 UTC 
Moving to ON_QA because Errata Tool did not do it
Comment 15 Markus Armbruster 2011-11-18 10:00:13 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause: Monitor command eject -f worked even for non-removable drives
Consequence: Unwise eject -f of non-removable drive made the drive unusable for guest (looks like bad hardware failure)
Fix: Refuse to eject non-removable drive
Result: User needs to be more creative to screw up his guest.
Comment 16 errata-xmlrpc 2011-12-06 16:04:45 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1531.html
Note You need to log in before you can comment on or make changes to this bug.