Spec URL: http://spot.fedorapeople.org/perl-Text-Aspell.spec SRPM URL: http://spot.fedorapeople.org/perl-Text-Aspell-0.09-10.fc15.src.rpm Koji Rawhide Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3397158 Description: This module provides a Perl interface to the GNU Aspell library. This module is to meet the need of looking up many words, one at a time, in a single session, such as spell-checking a document in memory. Review Note: This package was retired in Fedora due to being orphaned. I am reviving it to resolve broken dependencies.
Taking.
=== KEY === - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3399578 [x] Rpmlint output: perl-Text-Aspell.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Text/Aspell/Aspell.so Aspell.so()(64bit) perl-Text-Aspell.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Text/Aspell/Aspell.so Aspell.so()(64bit) 3 packages and 1 specfiles checked; 0 errors, 2 warnings. Spot, please add the perl default filter to your spec file. That will address this issue. %{?perl_default_filter} [x] Package is not relocatable. [x] Buildroot is correct None specified, default used. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. 67ec8b9c4769969fa714fc25c9c73832 Text-Aspell-0.09.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: fedora-rawhide-x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3399578 [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass All tests successful. Files=3, Tests=21, 0 wallclock secs ( 0.06 usr 0.00 sys + 0.12 cusr 0.02 csys = 0.20 CPU) Result: PASS Looks good. Add the filter to your spec file and I'll approve the package.
Filter added: New SPEC: http://spot.fedorapeople.org/perl-Text-Aspell.spec New SRPM: http://spot.fedorapeople.org/perl-Text-Aspell-0.09-11.fc15.src.rpm
Rpmlint is now silent. PAckage builds in mock. APPROVED.
Package Change Request ====================== Package Name: perl-Text-Aspell New Branches: f16 Owners: spot InitialCC: perl-sig This package is being unretired. It has no F-16 branch. I am happy to take ownership of f14 and f15 as well.
Git done (by process-git-requests). f16 created, devel unretired, please take ownership in pkgdb. Thanks!
perl-Text-Aspell-0.09-11.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Text-Aspell-0.09-11.fc16
Package perl-Text-Aspell-0.09-11.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing perl-Text-Aspell-0.09-11.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2011-14232 then log in and leave karma (feedback).
I'm sorry, but this package was orphaned for a reason. Major applications are now using hunspell instead of aspell (feature from F-9). All packages dependent on perl-Text-Aspell should be fixed to do not use it. You might didn't notice message on fedora-devel: http://lists.fedoraproject.org/pipermail/devel/2011-April/150919.html And last git commit in old repo says: Retired in favor of perl-Text-Hunspell.
(In reply to comment #9) > > All packages dependent on perl-Text-Aspell should be fixed to do not use it. I understood from the feature that applications would use hunspell but not that all other dictionaries would be removed from the distribution. Is this going to happen with OpenSSL once the Crypto Consolidation feature lands ? > You might didn't notice message on fedora-devel: > http://lists.fedoraproject.org/pipermail/devel/2011-April/150919.html I can't speak for Tom but I missed this. I was convinced that perl-Text-Aspell had been orphaned with devel or perl-devel being warned. > And last git commit in old repo says: > Retired in favor of perl-Text-Hunspell. This is extremely bad form. We've had broken deps in the distribution since April because this package was retired prematurely. acheck should have first built without it as a dependency.
(In reply to comment #9) > I'm sorry, but this package was orphaned for a reason. Major applications are > now using hunspell instead of aspell (feature from F-9). All packages dependent > on perl-Text-Aspell should be fixed to do not use it. > You might didn't notice message on fedora-devel: > http://lists.fedoraproject.org/pipermail/devel/2011-April/150919.html > > And last git commit in old repo says: > Retired in favor of perl-Text-Hunspell. This is ridiculous. There are clearly still Fedora packages using aspell. Should we kick all tcl apps out of Fedora on the grounds that they should be ported to gtk? What about qt? This package is functional. I am willing to maintain it. There are no legal concerns around it. Thus, it meets the criteria for inclusion.
perl-Text-Aspell-0.09-11.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.