Hide Forgot
- List bookmarks on the left side panel - Bookmarks dialog based view for adding new bookmarks
> List bookmarks on the left side panel Done and pushed, git commit hash 15451477719241e72fe10e1fafb7cb93e63938c2
> Bookmarks dialog based view for adding new bookmarks Done, New/Edit bookmark dialog, sending patch
New/Edit bookmark dialog pushed, git commit hash 9e59fd7e8f795c29ca28b18c0b89e749483a282e
Extending the scope of this BZ to the Bookmark action toolbar on the left pane as well.
Bookmark toolbar finished, action buttons bound to corresponding BookmarkListModel commands. There is still one issue with bookmarks: Assume user saves bookmark for search string "Host: name = dev-01". When user clicks this bookmark, following happens: 1) CommonModel.BookmarkListModel_Navigated() sets the search string according to bookmark value ("Host: name = dev-01"), search panel UI is updated 2) CommonModel.TagListModel_SelectedItemsChanged() resets the search string to "Host:", removing extra criteria, search panel UI is updated Need to investigate why 2) happens.
In CommonModel.BookmarkListModel_Navigated() method, getTagList().getResetCommand().Execute() causes TagListModel.Reset() -> TagListModel.SyncSearch(), which executes asynchronously after BookmarkListModel_Navigated() does its job. Therefore, TagListModel.Reset() causes the search string to be "resetted" to the default value for the given main tab, e.g. "Hosts:".
CommonModel.TagListModel_SelectedItemsChanged() patched, needs review from Gilad. Pinning a tag must deselect tree selection, otherwise CommonModel.SplitSearchString() will calculate wrong search/prefix strings when unpinning a tag.
In C# SystemTreeModel.ResetRequestedEvent is handled in a custom way, need to adapt that logic in webadmin.
closing ON_QA bugs as oVirt 3.1 was released: http://www.ovirt.org/get-ovirt/