Hide Forgot
PackageReview bugzilla for adding python-qpid to RHEL 5
Relevant files: http://download.devel.redhat.com/brewroot/packages/python-qpid/0.12/1.el6/src/python-qpid-0.12-1.el6.src.rpm http://cvs.devel.redhat.com/cgi-bin/cvsweb.cgi/rpms/python-qpid/RHEL-6/python-qpid.spec?rev=HEAD;content-type=text%2Fplain
Scratch build on el5: SRPM: http://download.devel.redhat.com/brewroot/work/tasks/4067/3694067/python-qpid-0.12-1.el5.src.rpm SPEC: http://cvs.devel.redhat.com/cgi-bin/cvsweb.cgi/rpms/python-qpid/RHEL-5-MRG/python-qpid.spec?rev=HEAD
Review as per the Fedora guidelines: MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint python-qpid-0.12-1.el5.src.rpm python-qpid-0.12-1.noarch.rpm python-qpid.src: W: non-standard-group Development/Python python-qpid.src:28: W: macro-in-comment %patch0 python-qpid.src: W: invalid-url Source0: python-qpid-0.12.tar.gz python-qpid.noarch: W: non-standard-group Development/Python python-qpid.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/qpid/disp.py 0644L /usr/bin/env python-qpid.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/qpid/tests/codec.py 0644L /usr/bin/env python-qpid.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/qpid/managementdata.py 0644L /usr/bin/env python-qpid.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/qpid/codec.py 0644L /usr/bin/env python-qpid.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/qpid/reference.py 0644L /usr/bin/env python-qpid.noarch: W: no-manual-page-for-binary qpid-python-test python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/api/server /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/reservations/inventory /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/api/hello_xml /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/reservations/reserve /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/api/drain /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/api/spout /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/api/hello /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/reservations/machine-agent /usr/bin/env 2 packages and 0 specfiles checked; 5 errors, 13 warnings. MUST: The package must be named according to the Package Naming Guidelines. - OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. - see invalid URL warning above. Maybe point diectly to the official qpid tarfile at http://www.apache.org/dyn/closer.cgi/qpid/0.12/qpid-python-0.12.tar.gz ? Still, I compared the md5sums against that URL, and they do match: $ rpm2cpio python-qpid-0.12-1.el5.src.rpm | cpio -ivd python-qpid-0.12.tar.gz python-qpid.spec 471 blocks $ md5sum python-qpid-0.12.tar.gz fad97bacec04e17ab6a6deb4b16ee31a python-qpid-0.12.tar.gz $ wget http://www.apache.org/dyn/closer.cgi/qpid/0.12/qpid-python-0.12.tar.gz --2011-10-10 16:40:10-- http://www.apache.org/dyn/closer.cgi/qpid/0.12/qpid-python-0.12.tar.gz Resolving www.apache.org... 140.211.11.131 Connecting to www.apache.org|140.211.11.131|:80... connected. HTTP request sent, awaiting response... 200 OK Length: unspecified [text/html] Saving to: “qpid-python-0.12.tar.gz” [ <=> ] 27,376 134K/s in 0.2s 2011-10-10 16:40:11 (134 KB/s) - “qpid-python-0.12.tar.gz” saved [27376] $ md5sum python-qpid-0.12.tar.gz fad97bacec04e17ab6a6deb4b16ee31a python-qpid-0.12.tar.gz MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - OK $ rpmbuild -ba python-qpid.spec Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.61468 + umask 022 + cd /home/boston/nsantos/rpmbuild/BUILD + cd /home/boston/nsantos/rpmbuild/BUILD + rm -rf python-qpid-0.12 + /usr/bin/gzip -dc /home/boston/nsantos/rpmbuild/SOURCES/python-qpid-0.12.tar.gz + tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd python-qpid-0.12 ++ /usr/bin/id -u + '[' 3400 = 0 ']' ++ /usr/bin/id -u + '[' 3400 = 0 ']' + /bin/chmod -Rf a+rX,u+w,g-w,o-w . + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.61468 + umask 022 + cd /home/boston/nsantos/rpmbuild/BUILD + cd python-qpid-0.12 + CFLAGS='-O2 -g -m64 -mtune=generic' + /usr/bin/python setup.py build running build running build_py creating build creating build/lib creating build/lib/mllib copying mllib/transforms.py -> build/lib/mllib copying mllib/__init__.py -> build/lib/mllib copying mllib/parsers.py -> build/lib/mllib copying mllib/dom.py -> build/lib/mllib creating build/lib/qpid copying qpid/compat.py -> build/lib/qpid copying qpid/client.py -> build/lib/qpid copying qpid/content.py -> build/lib/qpid copying qpid/ops.py -> build/lib/qpid copying qpid/delegate.py -> build/lib/qpid copying qpid/selector.py -> build/lib/qpid copying qpid/framing.py -> build/lib/qpid copying qpid/harness.py -> build/lib/qpid copying qpid/codec010.py -> build/lib/qpid copying qpid/peer.py -> build/lib/qpid copying qpid/datatypes.py -> build/lib/qpid copying qpid/codec.py -> build/lib/qpid copying qpid/concurrency.py -> build/lib/qpid copying qpid/validator.py -> build/lib/qpid copying qpid/__init__.py -> build/lib/qpid copying qpid/generator.py -> build/lib/qpid copying qpid/reference.py -> build/lib/qpid copying qpid/specs_config.py -> build/lib/qpid copying qpid/lexer.py -> build/lib/qpid copying qpid/mimetype.py -> build/lib/qpid copying qpid/debug.py -> build/lib/qpid copying qpid/delegates.py -> build/lib/qpid copying qpid/queue.py -> build/lib/qpid copying qpid/connection.py -> build/lib/qpid copying qpid/exceptions.py -> build/lib/qpid copying qpid/disp.py -> build/lib/qpid copying qpid/packer.py -> build/lib/qpid copying qpid/management.py -> build/lib/qpid copying qpid/util.py -> build/lib/qpid copying qpid/connection08.py -> build/lib/qpid copying qpid/managementdata.py -> build/lib/qpid copying qpid/sasl.py -> build/lib/qpid copying qpid/message.py -> build/lib/qpid copying qpid/testlib.py -> build/lib/qpid copying qpid/parser.py -> build/lib/qpid copying qpid/log.py -> build/lib/qpid copying qpid/framer.py -> build/lib/qpid copying qpid/spec08.py -> build/lib/qpid copying qpid/session.py -> build/lib/qpid creating build/lib/qpid/messaging copying qpid/messaging/constants.py -> build/lib/qpid/messaging copying qpid/messaging/__init__.py -> build/lib/qpid/messaging copying qpid/messaging/address.py -> build/lib/qpid/messaging copying qpid/messaging/transports.py -> build/lib/qpid/messaging copying qpid/messaging/exceptions.py -> build/lib/qpid/messaging copying qpid/messaging/driver.py -> build/lib/qpid/messaging copying qpid/messaging/util.py -> build/lib/qpid/messaging copying qpid/messaging/message.py -> build/lib/qpid/messaging copying qpid/messaging/endpoints.py -> build/lib/qpid/messaging creating build/lib/qpid/tests copying qpid/tests/framing.py -> build/lib/qpid/tests copying qpid/tests/codec010.py -> build/lib/qpid/tests copying qpid/tests/datatypes.py -> build/lib/qpid/tests copying qpid/tests/codec.py -> build/lib/qpid/tests copying qpid/tests/__init__.py -> build/lib/qpid/tests copying qpid/tests/mimetype.py -> build/lib/qpid/tests copying qpid/tests/queue.py -> build/lib/qpid/tests copying qpid/tests/spec010.py -> build/lib/qpid/tests copying qpid/tests/connection.py -> build/lib/qpid/tests copying qpid/tests/parser.py -> build/lib/qpid/tests creating build/lib/qpid/tests/messaging copying qpid/tests/messaging/__init__.py -> build/lib/qpid/tests/messaging copying qpid/tests/messaging/address.py -> build/lib/qpid/tests/messaging copying qpid/tests/messaging/message.py -> build/lib/qpid/tests/messaging copying qpid/tests/messaging/endpoints.py -> build/lib/qpid/tests/messaging creating build/lib/qpid/specs copying qpid/specs/amqp-0-10.dtd -> build/lib/qpid/specs copying qpid/specs/amqp-0-9.xml -> build/lib/qpid/specs copying qpid/specs/amqp-0-8.xml -> build/lib/qpid/specs copying qpid/specs/amqp-0-10-qpid-errata.xml -> build/lib/qpid/specs running build_scripts creating build/scripts-2.4 copying and adjusting qpid-python-test -> build/scripts-2.4 changing mode of build/scripts-2.4/qpid-python-test from 644 to 755 running build_doc No module named epydoc.docbuilder -- skipping build_doc + exit 0 Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.61468 + umask 022 + cd /home/boston/nsantos/rpmbuild/BUILD + cd python-qpid-0.12 + rm -rf /var/tmp/python-qpid-0.12-1-root-nsantos + /usr/bin/python setup.py install --skip-build --root /var/tmp/python-qpid-0.12-1-root-nsantos running install running install_lib creating /var/tmp/python-qpid-0.12-1-root-nsantos creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4 creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/mllib copying build/lib/mllib/transforms.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/mllib copying build/lib/mllib/__init__.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/mllib copying build/lib/mllib/parsers.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/mllib copying build/lib/mllib/dom.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/mllib creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/compat.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/client.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/content.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/ops.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/delegate.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/selector.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/framing.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/harness.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/codec010.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/peer.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/datatypes.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/codec.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/concurrency.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/validator.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/__init__.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/generator.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/reference.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/specs_config.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/lexer.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/mimetype.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/debug.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/delegates.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/queue.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/connection.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/exceptions.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/disp.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/packer.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/management.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/util.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/connection08.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/managementdata.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/sasl.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/message.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/testlib.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/parser.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/log.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/framer.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/spec08.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid copying build/lib/qpid/session.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging copying build/lib/qpid/messaging/constants.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging copying build/lib/qpid/messaging/__init__.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging copying build/lib/qpid/messaging/address.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging copying build/lib/qpid/messaging/transports.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging copying build/lib/qpid/messaging/exceptions.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging copying build/lib/qpid/messaging/driver.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging copying build/lib/qpid/messaging/util.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging copying build/lib/qpid/messaging/message.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging copying build/lib/qpid/messaging/endpoints.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests copying build/lib/qpid/tests/framing.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests copying build/lib/qpid/tests/codec010.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests copying build/lib/qpid/tests/datatypes.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests copying build/lib/qpid/tests/codec.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests copying build/lib/qpid/tests/__init__.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests copying build/lib/qpid/tests/mimetype.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests copying build/lib/qpid/tests/queue.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests copying build/lib/qpid/tests/spec010.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests copying build/lib/qpid/tests/connection.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests copying build/lib/qpid/tests/parser.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/messaging copying build/lib/qpid/tests/messaging/__init__.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/messaging copying build/lib/qpid/tests/messaging/address.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/messaging copying build/lib/qpid/tests/messaging/message.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/messaging copying build/lib/qpid/tests/messaging/endpoints.py -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/messaging creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/specs copying build/lib/qpid/specs/amqp-0-10.dtd -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/specs copying build/lib/qpid/specs/amqp-0-9.xml -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/specs copying build/lib/qpid/specs/amqp-0-8.xml -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/specs copying build/lib/qpid/specs/amqp-0-10-qpid-errata.xml -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/specs caching /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/specs/amqp-0-10-qpid-errata.xml to amqp-0-10-qpid-errata.pcl byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/mllib/transforms.py to transforms.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/mllib/__init__.py to __init__.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/mllib/parsers.py to parsers.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/mllib/dom.py to dom.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/compat.py to compat.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/client.py to client.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/content.py to content.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/ops.py to ops.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/delegate.py to delegate.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/selector.py to selector.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/framing.py to framing.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/harness.py to harness.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/codec010.py to codec010.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/peer.py to peer.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/datatypes.py to datatypes.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/codec.py to codec.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/concurrency.py to concurrency.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/validator.py to validator.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/__init__.py to __init__.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/generator.py to generator.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/reference.py to reference.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/specs_config.py to specs_config.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/lexer.py to lexer.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/mimetype.py to mimetype.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/debug.py to debug.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/delegates.py to delegates.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/queue.py to queue.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/connection.py to connection.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/exceptions.py to exceptions.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/disp.py to disp.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/packer.py to packer.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/management.py to management.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/util.py to util.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/connection08.py to connection08.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/managementdata.py to managementdata.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/sasl.py to sasl.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/message.py to message.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/testlib.py to testlib.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/parser.py to parser.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/log.py to log.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/framer.py to framer.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/spec08.py to spec08.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/session.py to session.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging/constants.py to constants.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging/__init__.py to __init__.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging/address.py to address.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging/transports.py to transports.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging/exceptions.py to exceptions.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging/driver.py to driver.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging/util.py to util.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging/message.py to message.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/messaging/endpoints.py to endpoints.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/framing.py to framing.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/codec010.py to codec010.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/datatypes.py to datatypes.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/codec.py to codec.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/__init__.py to __init__.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/mimetype.py to mimetype.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/queue.py to queue.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/spec010.py to spec010.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/connection.py to connection.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/parser.py to parser.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/messaging/__init__.py to __init__.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/messaging/address.py to address.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/messaging/message.py to message.pyc byte-compiling /var/tmp/python-qpid-0.12-1-root-nsantos/usr/lib/python2.4/site-packages/qpid/tests/messaging/endpoints.py to endpoints.pyc running install_scripts creating /var/tmp/python-qpid-0.12-1-root-nsantos/usr/bin copying build/scripts-2.4/qpid-python-test -> /var/tmp/python-qpid-0.12-1-root-nsantos/usr/bin changing mode of /var/tmp/python-qpid-0.12-1-root-nsantos/usr/bin/qpid-python-test to 755 + /usr/lib/rpm/brp-compress + /usr/lib/rpm/brp-strip + /usr/lib/rpm/brp-strip-static-archive + /usr/lib/rpm/brp-strip-comment-note Processing files: python-qpid-0.12-1 Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.72950 + umask 022 + cd /home/boston/nsantos/rpmbuild/BUILD + cd python-qpid-0.12 + DOCDIR=/var/tmp/python-qpid-0.12-1-root-nsantos/usr/share/doc/python-qpid-0.12 + export DOCDIR + rm -rf /var/tmp/python-qpid-0.12-1-root-nsantos/usr/share/doc/python-qpid-0.12 + /bin/mkdir -p /var/tmp/python-qpid-0.12-1-root-nsantos/usr/share/doc/python-qpid-0.12 + cp -pr LICENSE.txt NOTICE.txt README.txt examples/ /var/tmp/python-qpid-0.12-1-root-nsantos/usr/share/doc/python-qpid-0.12 + exit 0 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: /usr/bin/env /usr/bin/python python(abi) = 2.4 Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/python-qpid-0.12-1-root-nsantos Wrote: /home/boston/nsantos/rpmbuild/SRPMS/python-qpid-0.12-1.src.rpm Wrote: /home/boston/nsantos/rpmbuild/RPMS/noarch/python-qpid-0.12-1.noarch.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.32369 + umask 022 + cd /home/boston/nsantos/rpmbuild/BUILD + cd python-qpid-0.12 + rm -rf /var/tmp/python-qpid-0.12-1-root-nsantos + exit 0 MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. - N/A MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. - OK MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. - N/A MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. - N/A MUST: Packages must NOT bundle copies of system libraries. - OK MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. - N/A MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. - OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) - OK MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. - see errors above in rpmlint output MUST: Each package must consistently use macros. - OK MUST: The package must contain code, or permissable content. - OK MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). - N/A MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. - OK MUST: Header files must be in a -devel package. - N/A MUST: Static libraries must be in a -static package. - N/A MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. - N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} - N/A MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. - N/A MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. - N/A MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. - OK MUST: All filenames in rpm packages must be valid UTF-8. - OK SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. - N/A SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. - N/A SHOULD: The reviewer should test that the package builds in mock. - OK SHOULD: The package should compile and build into binary rpms on all supported architectures. - OK (noarch) SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. - OK (upstream testing before release) SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. - OK SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. - N/A SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. - N/A SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. - N/A SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. - N/A =============== So the only issues are the rpmlint errors (proper file permissions need to be set in the specfile) and the URL warning (which I'm ok with bypassing since the md5sum matches the sources I got manually)
Updated Files: SRPM: http://tross.fedorapeople.org/python-qpid-0.12-1.src.rpm SPEC: http://tross.fedorapeople.org/python-qpid.spec
$ rpmlint python-qpid-0.12-1.src.rpm python-qpid-0.12-1.noarch.rpm python-qpid.src: W: non-standard-group Development/Python python-qpid.noarch: W: non-standard-group Development/Python python-qpid.noarch: W: no-manual-page-for-binary qpid-python-test python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/api/server /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/reservations/inventory /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/api/hello_xml /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/reservations/reserve /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/api/drain /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/api/spout /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/api/hello /usr/bin/env python-qpid.noarch: W: doc-file-dependency /usr/share/doc/python-qpid-0.12/examples/reservations/machine-agent /usr/bin/env 2 packages and 0 specfiles checked; 0 errors, 11 warnings. ============== The file permission errors have been fixed, the URL has been fixed and the warnings look ok to bypass, so I'm approving the review, feel free to request the branch next.