Bug 743812 - cpg and cfg: Handle errors from totem_mcast
Summary: cpg and cfg: Handle errors from totem_mcast
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: corosync
Version: 6.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Jan Friesse
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks: 756082
TreeView+ depends on / blocked
 
Reported: 2011-10-06 07:29 UTC by Jan Friesse
Modified: 2012-06-20 12:22 UTC (History)
3 users (show)

Fixed In Version: corosync-1.4.1-5.el6
Doc Type: Bug Fix
Doc Text:
Cause Extremely overloaded corosync (pload). Consequence IPC messages can be lost without giving information to application nor user. Fix Internal calls to mcast is properly checked and error code is returned. Result Application using IPC can now properly handle inability to send IPC message in given moment and can try send message later.
Clone Of:
Environment:
Last Closed: 2012-06-20 12:22:43 UTC
Target Upstream Version:


Attachments (Terms of Use)
Proposed patch for cpg (4.13 KB, patch)
2011-10-06 07:29 UTC, Jan Friesse
no flags Details | Diff
Proposed patch for cfg (6.96 KB, patch)
2011-10-06 07:29 UTC, Jan Friesse
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0777 0 normal SHIPPED_LIVE corosync bug fix and enhancement update 2012-06-19 20:35:04 UTC

Description Jan Friesse 2011-10-06 07:29:06 UTC
Created attachment 526637 [details]
Proposed patch for cpg

Description of problem:
totem_mcast function can return -1 if corosync is overloaded. Sadly in
many calls of this functions was error code ether not handled at all, or
handled by assert.

Commit changes behaviour to ether return CS_ERR_TRY_AGAIN or put error
code to later layers to handle it.

Version-Release number of selected component (if applicable):
1.4.1

How reproducible:
https://bugzilla.redhat.com/show_bug.cgi?id=664969

Unit test:
https://bugzilla.redhat.com/show_bug.cgi?id=664969

Comment 1 Jan Friesse 2011-10-06 07:29:42 UTC
Created attachment 526638 [details]
Proposed patch for cfg

Comment 4 Jan Friesse 2012-03-07 07:24:29 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
Extremely overloaded corosync (pload).

Consequence
IPC messages can be lost without giving information to application nor user.

Fix
Internal calls to mcast is properly checked and error code is returned.

Result
Application using IPC can now properly handle inability to send IPC message in given moment and can try send message later.

Comment 10 errata-xmlrpc 2012-06-20 12:22:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0777.html


Note You need to log in before you can comment on or make changes to this bug.