Bug 744066 - Review Request: vide - programmer's terminal for vim
Summary: Review Request: vide - programmer's terminal for vim
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-06 21:31 UTC by Lukas Zapletal
Modified: 2013-05-07 08:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-05-07 08:04:40 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Lukas Zapletal 2011-10-06 21:31:04 UTC
Spec URL: https://raw.github.com/lzap/vide/master/vide.spec
SRPM URL: http://lzap.fedorapeople.org/fedora-packaging/vide/0.1.8-1/vide-0.1.8-1.fc15.src.rpm
Description:
Vide is very simple terminal that waits on DBUS. User is able to send commands
(using videx command) to named tabs, like executing compilation scripts,
programs or even debug things in the CLI. It works like in your favorite IDE
like Eclipse, Netbeans or IntelliJ IDEA.

Vide is written in Vala and it's homepage is at: https://github.com/lzap/vide

It's target platform is Fedora.

[lzap@lzapx vide]$ rpmlint /home/lzap/rpmbuild/RPMS/i686/vide-0.1.8-1.fc15.i686.rpm
vide.i686: W: no-manual-page-for-binary videx
vide.i686: W: no-manual-page-for-binary vide
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[lzap@lzapx vide]$ rpmlint /data/temp/koji/vide-0.1.8-1.fc15.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3410961

I am going to provide the man page quite soon. Will update this BZ.

Comment 1 Amir Hedayaty 2011-11-19 10:58:18 UTC
Thanks for the nice package, I also a big user of vim, I really enjoyed this
It does not look so nice at first glance, the fact that you can assign,
compile/run to tabs is pretty handy!

The following build-requirements are a little bit hard to work-around
BuildRequires:  pkgconfig(gtk+-2.0)
BuildRequires:  pkgconfig(vte)
BuildRequires:  pkgconfig(gee-1.0)
BuildRequires:  pkgconfig(gio-2.0)

Is it better to use gtk2-devel, cte-devel. libgee-devel, glib2-devel

Seems you are trying to open an unrelated pixmap not available of my fedora
Failed to open file '/usr/share/pixmaps/gnome-term.png': No such file or
directory

Another minor bug is the ability to handle duplicates, for example if 2
instances are running, quit one of them (maybe the older one). I had a few
crash experiences and when trying to invoke it again, there was an error "Could
not aquire DBUS name", after killing the old one it become OK.

Comment 2 Amir Hedayaty 2011-11-19 11:15:49 UTC
A few more things:
after install 
%{__rm} -rf $RPM_BUILD_ROOT
is not needed anymore, also %clean is not needed since fc13 


%defattr(-,root,root,-)
is not needed either

And I think you need to have gtk+-2.0,glib2, vte, and libgee as dependency as well

Comment 3 Amir Hedayaty 2011-11-19 11:28:58 UTC
Also 
BuildRoot is also deprecated from FC10

Comment 4 Lukas Zapletal 2012-04-17 12:37:19 UTC
@Amir - sorry I did not respond, notification email was filtered due to incorrect setting on my side. Will work on your remarks, thank you!

Comment 5 Lukas Zapletal 2012-04-19 10:23:58 UTC
Amir,

all your SPEC related remarks are pushed upstream:

https://github.com/lzap/vide/blob/7d61d3dee707c3bedbafcf952073f707e7fbab70/vide.spec

Icon was fixed too:

https://github.com/lzap/vide/commit/399726c4eccab16a1aad1bd43f8e7a10ac2bb010

I have also created new issue for duplicates: https://github.com/lzap/vide/issues/3 and will work on it later on.

Several other bugs and features were removed/added :-)

Thank you.

New spec file: https://github.com/lzap/vide/blob/master/vide.spec

Comment 6 Lukas Zapletal 2012-04-19 11:08:08 UTC
Had to push one additional fix - there is compatibility issue in rawhide/f17 with gee library:

http://lists.fedoraproject.org/pipermail/devel/2011-September/156615.html

So I am keeping pkgconfig there, its more convinient than to have if statement (which actually does not work by the way).

https://github.com/lzap/vide/commit/f0c7c790694a7059e56137986740f950116646a0

Tagging new version 0.1.16-1:

New spec file: https://github.com/lzap/vide/blob/master/vide.spec
(s)rpm: http://koji.fedoraproject.org/koji/taskinfo?taskID=4005088

Comment 7 Mario Blättermann 2012-09-21 21:50:49 UTC
Your package contains a systemd service file which is activated by dbus. See the packaging guidelines:
https://fedoraproject.org/wiki/Packaging:Systemd#Unit_Files

Comment 8 Lukas Zapletal 2013-04-30 16:00:54 UTC
Will do once anybody will take it for review.

Comment 9 Jason Tibbitts 2013-04-30 22:38:43 UTC
Why would anyone review a package they know doesn't meet the packaging guidelines?  In any case, there doesn't appear to be any way to get the srpm in order to review the package.  The only thing you provide is a link to a build in koji which was garbage collected long ago.  (Files from scratch builds are only kept for two weeks.)

If you need a place to store your files, just use your fedorapeople space.


Note You need to log in before you can comment on or make changes to this bug.