Bug 744137 - Automatic disk naming in virt-manager has flaws
Summary: Automatic disk naming in virt-manager has flaws
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On: 684150
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-07 08:22 UTC by Alexander Todorov
Modified: 2014-07-06 19:31 UTC (History)
11 users (show)

Fixed In Version:
Clone Of: 684150
Environment:
Last Closed: 2013-10-02 23:59:03 UTC
Embargoed:


Attachments (Terms of Use)

Description Alexander Todorov 2011-10-07 08:22:11 UTC
+++ This bug was initially created as a clone of Bug #684150 +++

--- Additional comment from atodorov on 2011-08-15 13:38:44 EEST ---

Hi folks,
i'm not sure if this is desired behavior or I'm hitting another issue. Please let me know:

1) I already have a disk named t1.img
2) I create new guest named t2 and assign the t1.img as it's first disk (name is important, it is different from guest name)
3) Then I select to customize the configuration and start adding additional disks
4) Select to create a new virtio disk image. It will be named t2.img
5) Add one more disk. Again create new one. 

Actual Results:
Upon adding the 3rd disk I already have t1.img and t2.img created. virt-manager tells me that t2.img storage already exists but is not in use by any virtual machine. It will ask the user if they want to use the existing disk image or not. 

If you select No then a new image file called t2-1.img will be created. 
If you select Yes then the 3rd disk will be assigned the same path as the second disk.


Expected results:
I expect that since t2.img is already assigned virt-manager will not ask me about it and create the t2-1.img, t2-2.img and so on. 

I suspect the cause for this is that when checking if disk images are in use virt-manager will check only for existing guests but not for guests which are about to be created.

--- Additional comment from atodorov on 2011-08-15 13:39:16 EEST ---

Created attachment 518247 [details]
screenshot of dialog

Comment 1 Cole Robinson 2011-12-09 22:12:10 UTC
Not urgent, and given reduced capacity for virt-manager/virtinst, just moving
this to the upstream tracker.

Comment 2 Cole Robinson 2013-10-02 23:59:03 UTC
Fixed upstream now


Note You need to log in before you can comment on or make changes to this bug.