Hide Forgot
Spec URL: http://fedorapeople.org/gitweb?p=grover/public_git/python-rtslib.git;a=blob;f=python-rtslib.spec;h=e3959979da1a844815d2936cd4a7e9974252e6e5;hb=7578acbe59f634ebe2cab78bcdb92aa810b7b472 SRPM URL: http://grover.fedorapeople.org/srpms/python-rtslib-1.99.1.git644eece-7.el6.src.rpm Description: This packaging was previously reviewed by dmalcolm for RHEL. This is a dependency for bug 744340.
Review follows: What needs work: - usual s/define/global - version in changelog differs from Version: python-rtslib.noarch: W: incoherent-version-in-changelog 1.9.9-7 ['1.99.1.git644eece-7.fc16', '1.99.1.git644eece-7' - my checkout produces different md5sum, could you check: 7c9c0220bba3773639b3e33ffa8d9d22 ../SOURCES/rtslib-1.99.1.git644eece.tar.gz ace89d9b619277b52e7bde5760418502 rtslib-1.99.1.git644eece.tar.gz What's good: - *pyo, *pyc and egg-info files are properly included - name is fine (module version) - license is fine - all files are owned by package - macro use is consistent - it builds - permissions are fine
Updated spec URL: http://fedorapeople.org/gitweb?p=grover/public_git/python-rtslib.git;a=blob;f=python-rtslib.spec;h=58ab9c5f68fec5b9b8e6b8295097714eecb31cdf;hb=3e5f448a6b0436a88f836be1f4a4765e71cdeff2 Updated SRPM URL: http://grover.fedorapeople.org/srpms/python-rtslib-1.99.1.git644eece-8.el6.src.rpm Changed checkout instructions to use gzip -n option, hopefully this will help create a tarball with identical bits: 758c519cad364f290320918719db71ea rtslib-1.99.1.git644eece.tar.gz Fixed other issues, thanks as always!
Great, but Changelog version still misses a bit (or snapshot version lacks a dot): 1.99.1.git644eece-8 (spec) 1.9.9.1.git644eece-8 (ChangeLog) You are a dot away of being granted a approval.
allrighty, done: http://fedorapeople.org/gitweb?p=grover/public_git/python-rtslib.git;a=blob;f=python-rtslib.spec;h=e36855f4b1062a326e70b8089c588bff19f5e7df;hb=e04d5693c57fd52cac6e094d643aa138cfac7324
OK, all my remarks are fixed. Thank you, I'm granting a review. (My FAS account is "ttorcz").
New Package SCM Request ======================= Package Name: python-rtslib Short Description: Python API for generic SCSI target Owners: grover Branches: f16 InitialCC: ttorcz
Thanks for the reviews, Tomasz!
Git done (by process-git-requests).