Bug 744671 - Option to enable 'Enter' to save and move to the next string and use Shift+Enter to add a new line
Summary: Option to enable 'Enter' to save and move to the next string and use Shift+En...
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Zanata
Classification: Retired
Component: Component-UI
Version: 1.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 1.4.2
Assignee: Runa Bhattacharjee
QA Contact: Ding-Yi Chen
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: 740191 Zanata-1.4.2
TreeView+ depends on / blocked
 
Reported: 2011-10-10 05:55 UTC by James Ni
Modified: 2013-03-04 02:22 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2011-10-28 07:02:42 UTC


Attachments (Terms of Use)

Description James Ni 2011-10-10 05:55:10 UTC
As a translator I want a to set an Option to enable 'Enter' to save and move to the next string and use Shift+Enter to add a new line, so that I can quickly edit and navigate while working on on the editor

-add options menu to enable 'Enter' to save and move to the next string
-dynamically change tooltips for Save as Approved button

Comment 2 Ding-Yi Chen 2011-10-12 02:11:45 UTC
James, this bug is re-assigned to you because:

1. Ctrl-Enter should still be working as "Saved as Approved" when "Enable 'Enter' Key to save" is off.

2. Shift-Enter should be able to insert the newline, no matter "Enable 'Enter' Key to save" is on or off.

Comment 3 James Ni 2011-10-12 06:01:51 UTC
(In reply to comment #2)
> James, this bug is re-assigned to you because:
> 
> 1. Ctrl-Enter should still be working as "Saved as Approved" when "Enable
> 'Enter' Key to save" is off.
> 
> 2. Shift-Enter should be able to insert the newline, no matter "Enable 'Enter'
> Key to save" is on or off.

OK, I will reinstate the Ctrl-Enter, and make 'Shift-Enter' be able to insert the newline, when "Enable 'Enter' Key to save" is on

Comment 4 James Ni 2011-10-12 08:04:42 UTC
Hi Ding,

I have modified the code to reinstate Ctrl-Enter to be working as "Saved as Approved" when "Enable 'Enter' Key to save" is off.

I also found that Shift-Enter should be able to insert the newline when "Enable 'Enter' Key to save" is off. And we don't need any further key event handler for Shift-Enter when "Enable 'Enter' Key to save" is off.

Comment 5 Sean Flanigan 2011-10-14 06:28:32 UTC
Dean, are you happy with this now?

Comment 6 Ding-Yi Chen 2011-10-17 00:58:38 UTC
VERIFIED with Zanata version 1.4.2-SNAPSHOT (20111014-1658).


Note You need to log in before you can comment on or make changes to this bug.