Hide Forgot
Description of problem: Greg Hudson ran into an issue while reviewing my patch to add support for using NSS to MIT Kerberos's PKINIT implementation: SECMOD_LoadUserModule() apparently returns non-NULL values when it fails to load a module. This appears to conflict with what the documentation says: https://developer.mozilla.org/en/NSS_PKCS11_Functions#SECMOD_LoadUserModule Version-Release number of selected component (if applicable): nss-3.12.10-7.fc16.x86_64 How reproducible: Always Steps to Reproduce: 1. Build test. 2. Invoke test with a bogus plugin name (e.g., "./pk11test nosuchmodule.so") Actual results: Test gets a non-NULL value back from SECMOD_LoadUserModule(), passes it to SECMOD_UpdateSlotList(), and crashes. Expected results: A NULL result? Or is the documentation wrong?
Created attachment 527328 [details] sample program
Comment on attachment 527328 [details] sample program > if (module == NULL) { > printf("error loading %s\n", library); > return 2; > } ... The condition above should be (module == NULL || !module->loaded) I guess.
Well that's the crux of it. The docs don't mention that.
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19
This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.