Bug 745020 - disable libxl on non-x86 arches
Summary: disable libxl on non-x86 arches
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt
Version: 16
Hardware: s390x
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fedora Virtualization Maintainers
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-11 08:25 UTC by Dan Horák
Modified: 2011-10-11 23:50 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-10-11 23:50:41 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Dan Horák 2011-10-11 08:25:34 UTC
Description of problem:
libxl support needs to be explicitly disabled on non-x86 arches otherwise build fails with 
...
Processing files: libvirt-0.9.6-2.fc16.s390
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.cld2Hu
error: Directory not found: /builddir/build/BUILDROOT/libvirt-0.9.6-2.fc16.s390/var/log/libvirt/libxl
error: Directory not found: /builddir/build/BUILDROOT/libvirt-0.9.6-2.fc16.s390/var/run/libvirt/libxl
error: Directory not found: /builddir/build/BUILDROOT/libvirt-0.9.6-2.fc16.s390/var/lib/libvirt/libxl
+ umask 022
+ cd /builddir/build/BUILD
...

Version-Release number of selected component (if applicable):
libvirt-0.9.6-2.fc16

For full logs please see
http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=470366

Comment 1 Laine Stump 2011-10-11 15:15:04 UTC
Dan,

I see you've already fixed it in both F16 and rawhide git. Thanks for correcting this oversight. To make sure this change doesn't get lost in a future update from upstream, could you post a patch to libvir-list? (since libvirt.spec is a generated file, the file to patch will be libvirt.spec.in)

Comment 3 Eric Blake 2011-10-11 23:50:41 UTC
Now upstream; next rebase (0.9.7) will get it automatically, and current libivrt.spec can point back to this upstream commit if we release 0.9.6-4.

commit 099dc93b7c39dd84fe2ae573f3cb782dd0051028
Author: Dan Horák <dan>
Date:   Tue Oct 11 17:30:50 2011 +0200

    disable xenlight for non-Xen platforms
    
    when building libvirt in Fedora/s390x I've found that xenlight needs to
    be explicitly disabled in the spec file. Configure properly sets the
    library as non-existent, but the %files section still wants to package
    the 3 /var/*/libvirt/libxl directories. See also
    https://bugzilla.redhat.com/show_bug.cgi?id=745020


Note You need to log in before you can comment on or make changes to this bug.