Bug 745702 - Tab completion should work with characters instead of bytes
Summary: Tab completion should work with characters instead of bytes
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: mksh
Version: 16
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
Assignee: Robert Scheck
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 771198
TreeView+ depends on / blocked
 
Reported: 2011-10-13 06:38 UTC by Petr Šabata
Modified: 2013-01-17 08:05 UTC (History)
3 users (show)

Fixed In Version: mksh-40i-0.fc18.20120630.x86_64
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 771198 (view as bug list)
Environment:
Last Closed: 2013-01-17 08:05:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
fix from mksh CVS (627 bytes, patch)
2011-12-29 23:40 UTC, Thorsten Glaser
no flags Details | Diff

Description Petr Šabata 2011-10-13 06:38:34 UTC
Description of problem:
Tab completion in mksh seems to work with bytes, not characters.  This results in a poor user experience when working with filenames in multibyte encodings.

Version-Release number of selected component (if applicable):
mksh-40b-2.fc15.x86_64

How reproducible:
Always

Steps to Reproduce:
1. mkdir t && touch t/십일 t/십이
2. Type 'ls t/' and hit <TAB>
  
Actual results:
t/십�

Expected results:
t/십

Additional info:
This should be reproducible with anything beyond ASCII range with UTF-8.

Comment 1 Robert Scheck 2011-12-25 22:59:30 UTC
Thorsten, this sounds like something for you as upstream.

Comment 2 Thorsten Glaser 2011-12-26 20:02:09 UTC
Agreed (thanks for the testcase and bringing it to my attention),
especially as the line editor behaves funnily afterwards… will fix.

Comment 3 Thorsten Glaser 2011-12-29 23:40:31 UTC
Created attachment 550003 [details]
fix from mksh CVS

fixed upstream, thanks for the report

Comment 4 Petr Šabata 2012-01-02 09:53:53 UTC
Works like a charm, thank you for the fix!

Comment 5 Robert Scheck 2012-01-02 09:57:17 UTC
Petr: Can you try to backport this patch into RHEL 6?

Thorsten: How far is the next mksh release? Shall I wait?

Comment 6 Thorsten Glaser 2012-01-02 10:25:32 UTC
Robert: probably in 2-3 weeks, depending on the feedback I get for what’s
currently in the CVS branch R40-stable which I uploaded to Debian unstable.
You might want to package that (I just used R40d and a diff between that
and the current head of the R40-stable branch) in the meantime if you can’t
live without this fix. Be aware it contains less tested changes to the per-
sistent history code (which is why I’m reluctant to release now).

See also the recent mails on miros-mksh@ (via GMane)

Comment 7 Petr Šabata 2012-01-02 12:23:01 UTC
(In reply to comment #5)
> Petr: Can you try to backport this patch into RHEL 6?

This is a task for its RHEL maintainer, Michal Hlavinka (CC'd already).
I'll clone this bug for RHEL6.

Comment 8 Fedora End Of Life 2012-08-06 20:08:40 UTC
This message is a notice that Fedora 15 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 15. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '15' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 15 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 9 Fedora End Of Life 2012-08-06 20:08:40 UTC
This message is a notice that Fedora 15 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 15. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '15' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 15 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 10 Petr Šabata 2012-08-07 08:09:13 UTC
Still present in the current releases.

Comment 11 Thorsten Glaser 2012-08-07 11:46:52 UTC
Not present in mksh-current. Note you need “set -U”, i.e. Unicode mode enabled.

Comment 12 Fedora End Of Life 2013-01-17 00:17:10 UTC
This message is a reminder that Fedora 16 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 16. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '16'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 16's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 16 is end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" and open it against that version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 13 Petr Šabata 2013-01-17 08:05:45 UTC
Works in Fedora 18, finally -- which is good enough for me now.
Closing with my current version.


Note You need to log in before you can comment on or make changes to this bug.