Bug 745734 - Check for domain being active on successful job acquire
Summary: Check for domain being active on successful job acquire
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.2
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Michal Privoznik
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 748554
TreeView+ depends on / blocked
 
Reported: 2011-10-13 09:08 UTC by Michal Privoznik
Modified: 2011-12-06 11:37 UTC (History)
7 users (show)

Fixed In Version: libvirt-0.9.4-18.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-06 11:37:21 UTC
Target Upstream Version:

Attachments (Terms of Use)
repro.sh (234 bytes, text/plain)
2011-10-13 09:09 UTC, Michal Privoznik 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:1513 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2011-12-06 01:23:30 UTC

Description Michal Privoznik 2011-10-13 09:08:04 UTC 
Description of problem:
In libvirt QEMU driver locking whole domain is not desired, esp. during sleeps we came up with so called job conditions. That is, after obtaining lock for domain we try to set a job on it. During setting job, domain might get unlocked, thus its state might get changed. Therefore, after every successful job acquire we need to check if domain is still alive. Okay, there are a few exceptions (e.g. starting a domain). Otherwise, if we don't check we might end up trying to lock/access NULL monitor.

Version-Release number of selected component (if applicable):
libvirt-0.9.4-17.el6

How reproducible:
100%

Steps to Reproduce:
1. run attached reproducer and pass it a domain name
2. observe daemon crash
3.
  
Actual results:
libvirtd crashes


Expected results:
libvirtd will not crash

Additional info:
Comment 1 Michal Privoznik 2011-10-13 09:09:09 UTC 
Created attachment 527909 [details]
repro.sh
Comment 2 Michal Privoznik 2011-10-13 09:16:24 UTC 
Moving to POST:

http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-October/msg00398.html
Comment 6 yanbing du 2011-10-18 09:16:01 UTC 
Bug verified.

rpm packages version:
libvirt-0.9.4-18.el6.x86_64
qemu-kvm-0.12.1.2-2.197.el6.x86_64
kernel-2.6.32-210.el6.x86_64
Comment 7 errata-xmlrpc 2011-12-06 11:37:21 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1513.html
Note You need to log in before you can comment on or make changes to this bug.