Bug 745952 - cxgb4: remove forgotten real_num_tx_queues inicialization
Summary: cxgb4: remove forgotten real_num_tx_queues inicialization
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel
Version: 6.2
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Jiri Pirko
QA Contact: Network QE
URL:
Whiteboard:
Depends On:
Blocks: 767187
TreeView+ depends on / blocked
 
Reported: 2011-10-13 14:07 UTC by Jiri Pirko
Modified: 2015-05-05 01:23 UTC (History)
5 users (show)

Fixed In Version: kernel-2.6.32-231.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-20 07:57:20 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0862 0 normal SHIPPED_LIVE Moderate: Red Hat Enterprise Linux 6 kernel security, bug fix and enhancement update 2012-06-20 12:55:00 UTC

Description Jiri Pirko 2011-10-13 14:07:32 UTC 
Description of problem:

following commit:
    
    upstream commit a57cabe09f843a3f71277c485494496b3b9ee84a
    Author: Dimitris Michailidis <dm>
    Date:   Tue Dec 14 21:36:46 2010 +0000
    
        cxgb4: set the number of queues before device registration
    
        The number of queues is known early, move the calls to
        netif_set_real_num_[rt]x_queues before register_netdev.
    
Was backpored as part of rhel commit b661ac107541c93bc70f4373cfdabaebaea07358
but first hunk was missed.
    
Now it causes no problem because the value is same as previously correctly set up in init_one. But in the future this might cause issues if value gets changed only on one place.
    
So just add the missing hunk to remove the line.
Comment 2 RHEL Program Management 2011-12-13 04:37:05 UTC 
This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.
Comment 3 Aristeu Rozanski 2012-02-15 19:55:22 UTC 
Patch(es) available on kernel-2.6.32-231.el6
Comment 6 Weibing Zhang 2012-05-25 02:07:20 UTC 
Verified on kernel-2.6.32-270.el6.
netif_set_real_num_tx_queues(dev, pi->nqsets); // this line is removed.
Run NIC driver test for cxgb4 kernel-2.6.32-270.el6 and all the tests passed.
Set Verified.
Comment 8 errata-xmlrpc 2012-06-20 07:57:20 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0862.html
Note You need to log in before you can comment on or make changes to this bug.