Bug 746028 - nspluginwrapper should not wrap 64-bit plugins by default
Summary: nspluginwrapper should not wrap 64-bit plugins by default
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: nspluginwrapper
Version: 15
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Martin Stransky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 747981
TreeView+ depends on / blocked
 
Reported: 2011-10-13 17:19 UTC by Dan Davis
Modified: 2011-12-27 15:44 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 747981 (view as bug list)
Environment:
Last Closed: 2011-10-20 15:46:39 UTC
Type: ---


Attachments (Terms of Use)

Description Dan Davis 2011-10-13 17:19:56 UTC
Description of problem:
Since Firefox has its own plugin container, nspluginwrapper is not needed for 64-bit plugins.  This is even advised against upstream (http://nspluginwrapper.org/why.html).  nspluginwrapper should only scan for and wrap 32-bit plugins by default.

Version-Release number of selected component (if applicable):


How reproducible:
Every time a non-white-listed 64-bit plugin is installed.



Steps to Reproduce:
1. Install a 64 bit Firefox plugin not listed in /etc/sysconfig/nspluginwrapper IGNORE_WRAP. (such as 64-bit Flash)
2. Run mozilla-plugin-config
3. Run the plugin
  
Actual results:
The plugin is wrapped through nspluginwrapper instead of being loaded directly into Firefox.  This results in larger overhead for no benefit, with plugin-container holding npviewer.bin holding the plugin.

Expected results:
The plugin should not be wrapped.

Additional info:

Comment 1 Martin Stransky 2011-10-20 15:46:39 UTC
If you don't want the wrapped plug-ins, just remove nspluginwrapper. I don't see much sense in such change.

Comment 2 Dan Davis 2011-10-20 22:08:33 UTC
Glad to see you just closed the bug before asking for clarification.  Redhat employees hard at work.

The point is that I install nspluginwrapper on my x86_64 machine to wrap 32-bit plugins.  As far as I know, to wrap a 32-bit plugin, I have to install the 32-bit and 64-bit packages.  But that means that all my 64-bit plugins are being wrapped and don't need to be.  That's extra overhead for absolutely no benefit.  

That means every time I install another 64-bit plugin, I have to edit /etc/sysconfig/nspluginwrapper to exclude it.  Rather, I'd like to just have it wrap my 32-bit plugins by default, since the 64-bit ones work just fine and receive no benefit from it.

If you don't want your default system to be more efficient with no loss of functionality, that's your problem.

Comment 3 Martin Stransky 2011-10-21 06:43:29 UTC
Which 32-bit plug-ins plug-ins do you need to wrap on 64-bit systems? And do you think that change is important for all users? Because it's a big change to the wrapper functionality/logic. And other users may ask why the 64-bit plug-ins are not wrapper although the 64-bit wrapper is installed.

Comment 4 Dan Davis 2011-10-21 13:18:29 UTC
I suppose now that flash has native 64-bit support, the Adobe reader plugin is the only 32-bit plugin I have left being wrapped.  Do I absolutely need it?  No.  I could just download pdf's and view them outside of Firefox.  But it's a convenience issue.

As for if it's an important change for all users, the upstream supplier of nspluginwrapper seems to think so.

http://nspluginwrapper.org/why.html

Halfway down the page it says "It is not recommended to use nspluginwrapper for plugins which already run natively out-of-process in a modern browser. They should still work, but it only adds overhead."

My understanding is that since the late end of Firefox 3, Firefox has had plugin-container, which is running plugins out-of-process.

It should only be a minor change because all you have to do is change which directories are scanned for plugins, right?  I thought that's what the -3 and -6 options on mozilla-plugin-config was supposed to do, but it seems that instead they determine whether to wrap plugins to 32-bit or 64-bit systems, not to wrap from those systems.

Comment 5 Martin Stransky 2011-10-21 15:36:36 UTC
yes, the plug-ins should not be double-wrapped. When nspuginwrapper is installed, plugin-container (firefox OOP) should be disabled. I filled Bug 747981 for that.

But I still think the change you request is too invasive.

Comment 6 Kevin Kofler 2011-10-30 04:20:13 UTC
> I suppose now that flash has native 64-bit support, the Adobe reader plugin is
> the only 32-bit plugin I have left being wrapped.  Do I absolutely need it? 
> No.  I could just download pdf's and view them outside of Firefox.  But it's a
> convenience issue.

yum install kpartsplugin kdegraphics
or on Fedora 16 and later:
yum install kpartsplugin okular

Enjoy!

You don't need proprietary software to view PDFs in a browser.

Comment 7 Kevin Kofler 2011-10-30 04:26:38 UTC
BTW, Okular can also view many document formats Adobe Reader cannot view, e.g. PostScript, DVI etc.

Comment 8 Julian Sikorski 2011-12-27 15:44:30 UTC
If this change is too invasive to be the default, how about a config option? I would like to only wrap adobe reader, leaving other plugins natively.
I read somewhere that it is actually the default upstream behaviour which Fedora has changed.


Note You need to log in before you can comment on or make changes to this bug.