Bug 746669 - Recent alerts portlet seems broken
Summary: Recent alerts portlet seems broken
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Core UI
Version: 4.1
Hardware: All
OS: All
urgent
urgent
Target Milestone: ---
: ---
Assignee: Ian Springer
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-17 13:41 UTC by Jay Shaughnessy
Modified: 2013-08-06 00:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Embargoed:

Attachments (Terms of Use)

Description Jay Shaughnessy 2011-10-17 13:41:24 UTC 
1) Generate alerts

2) Visit Global Dash

Recent Alerts portlet is empty.

The alert history and report views seem to be working so it does not seem to be an underlying issue with the AlertHistoryView.  But something seems wrong.  If this portlet is broken then we better qualify others as well.
Comment 1 Ian Springer 2011-10-17 15:59:40 UTC 
This was an existing bug that was flushed out by my recent changes to Table.refresh(). Most of our Table subclasses call setDataSource() in their constructor to set the Table's dataSource. However, AbstractRecentAlertsPortlet and some other subclasses instead override getDataSource() in order to set the dataSource. Table was using this.dataSource, rather than getDataSource(), in a number of places, which ends up returning null for the latter group of subclasses (since setDataSource() was never called by the subclass). The fix is for Table to always call getDataSource() when it needs the dataSource.

[master fd5370e] (http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commitdiff;h=fd5370e)
Comment 2 Mike Foley 2011-10-18 14:53:02 UTC 
verified
Comment 3 Mike Foley 2012-02-07 19:30:27 UTC 
changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE
Comment 4 Mike Foley 2012-02-07 19:30:39 UTC 
marking VERIFIED BZs to CLOSED/CURRENTRELEASE
Note You need to log in before you can comment on or make changes to this bug.