Bug 746849 - curl does not support --delegation even though it was added to libcurl
Summary: curl does not support --delegation even though it was added to libcurl
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: curl
Version: 5.7
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Kamil Dudka
QA Contact: Dalibor Pospíšil
URL:
Whiteboard:
Depends On: 730445
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-17 23:50 UTC by Jr Aquino
Modified: 2012-10-10 09:47 UTC (History)
4 users (show)

Fixed In Version: curl-7.15.5-15.el5
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-21 06:15:34 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
backport of upstream commits 5538904 and 8bd877d (4.06 KB, patch)
2011-10-27 09:47 UTC, Kamil Dudka
ovasik: review+
Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0241 0 normal SHIPPED_LIVE curl bug fix and enhancement update 2012-02-20 15:07:27 UTC

Description Jr Aquino 2011-10-17 23:50:22 UTC
Description of problem:
libcurl was backported/updated to support credential delegation.  The curl binary itself appears to be missing the flag entirely.

Version-Release number of selected component (if applicable):
curl-7.15.5-9.el5_7.4

How reproducible:
100%

Steps to Reproduce:
1. curl --delegation
2. curl: option --delegation: is unknown

Actual results:
curl --delegation
curl: option --delegation: is unknown

Expected results:
curl --delegation
curl: option --delegation: requires parameter

Additional info:

Comment 1 Kamil Dudka 2011-10-18 06:37:23 UTC
This is known issue.  We already track an el6 sibling of this bug: bug 730445

Comment 6 Kamil Dudka 2011-10-27 09:47:15 UTC
Created attachment 530452 [details]
backport of upstream commits 5538904 and 8bd877d

Comment 7 Ondrej Vasik 2011-10-27 14:23:02 UTC
Comment on attachment 530452 [details]
backport of upstream commits 5538904 and 8bd877d

Looks sane, the only thing I was worried about was if the warnf is handling char * str correctly. I found one strange thing in the function though - two va_start(ap, fmt);
calls ... however, this is not coming from your patch (and is fixed in Fedora).

Comment 8 Kamil Dudka 2011-10-27 17:30:00 UTC
Good catch.  This was fixed in the following upstream commit:

https://github.com/bagder/curl/commit/c0f3e32

... but I did not find any problems resulting from this mistake reported on the upstream mailing list.  I am not sure whether it should be fixed with this bug since it has wider scope than the --delegation option of curl.

Do you have any preferences on that?

Comment 9 Ondrej Vasik 2011-10-27 17:50:00 UTC
I think we could keep it there as it is - it seems to be harmless - and has no connection with your patch.

Comment 10 Kamil Dudka 2011-10-27 21:59:03 UTC
Then I will apply the current version of the patch.  Thanks for review!

Comment 19 errata-xmlrpc 2012-02-21 06:15:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0241.html


Note You need to log in before you can comment on or make changes to this bug.