Red Hat Bugzilla – Bug 746870
Save as NeedReview should leave the cell editor open
Last modified: 2011-10-28 03:02:50 EDT
Description of problem:
Some people use "Save as NeedReview" for save the unfinished work of lengthy translation, in this case, the cell editor should be left open.
However, current zanata instance immediately close the cell editor, this is not very convenient.
Version-Release number of selected component (if applicable):
Zanata version 1.4.2-SNAPSHOT (20111018-1316)
Steps to Reproduce:
1. Visit the message list view of any document, version, and project.
2. Type "hi" in row 1 translation.
3. Press Ctrl-S (Keyboard shortcut for Save as NeedReview"
Cell editor closed immediately.
Cell editor should remain open for further editing.
Problem fixed. See https://github.com/zanata/zanata/commit/0085dc7482aed3e1a9d7a8b6b6464059a81a86f3
VERIFIED with Zanata version 1.4.2-SNAPSHOT (20111020-1402)
The keyboard shortcut and the onscreen button for 'needs review' display different behaviour.
Ctrl+s - saves the unit as 'needs review' and keeps the focus on the cell for the user to continue typing
Flag button - saves the unit as 'needs review' but supresses the focus. The cell remains highlighted but not focused for editing. The user has to click once again inside the cell to get the cursor back.
Fix bug: https://github.com/zanata/zanata/commit/daa2bfa14d51edb8507b91e25b39404b960c131d
With firefox-3.6.18 and firefox-3.6.20
The new version introduces that: pressing ctrl-s bring up Firefox's "Save Page as", instead of "Save as NeedReview".
The new version works well otherwise.
Thus this bug is re-ASSIGNED.
I can't reproduce that on firefox-3.6.18. In any case, there's only so much we can do about shortcuts in the browser environment. The house always wins.
If there's a lot of demand, we could try to find an alternative shortcut, but I'm not sure this feature will be used often enough to deserve it.
As an alternative, you can press Tab twice, then Enter.
Need more info on how reproducible it is. Tested on Firefox 7 and Chrome, both works fine.
This is reproducible if you have enabled input method then press Ctrl-S.
Chrome works as expect, so does ibus-1.4/Firefox7/Fedora 16.
But Ctrl-S still invokes "Save As" popup with ibus-1.3.4, Firefox-3.6.18 (RHEL6) and scim-1.4.4, Firefox-3.6.20 (RHEL5).
I deem this bug as VERIFIED with Zanata version 1.4.2-SNAPSHOT (20111025-0954), yet I might put another bug if it's not ibus's bug.
The Ctrl-S shortcut is just a bonus. If it works, great, if not the user has to use the mouse or press Tab-Tab-Enter.