Spec URL: http://kumarpraveen.fedorapeople.org/transmission-remote-gtk/transmission-remote-gtk.spec SRPM URL: http://kumarpraveen.fedorapeople.org/transmission-remote-gtk/transmission-remote-gtk-0.7-1.fc16.src.rpm Description: transmission-remote-gtk is a GTK client for remote management of the Transmission BitTorrent client, using its HTTP RPC protocol. Koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3440978
I'm the maintainer of this project. Thanks Praveen for submitting, and Arun for volunteering to review. I'm also a Fedora user, so I'd really like to see it included. Let me know if there's anything I can do to assist with the packaging or review. I'd be happy to make any upstream changes which are required. I have two suggestions for the spec file. If you don't wish to build the package with GeoIP support and include it as a Requires/BuildRequires, consider using the --without-libgeoip flag on ./configure to explicitly disable it. Also, icons are installed into the hicolor theme, so I think the spec file should include snippets to update the icon cache. See the "Icon Cache" section here: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets Regards,
Thanks for suggestions Alan, done changes as you suggested updated spec/srpm SPEC : http://kumarpraveen.fedorapeople.org/transmission-remote-gtk/transmission-remote-gtk.spec SRPM : http://kumarpraveen.fedorapeople.org/transmission-remote-gtk/transmission-remote-gtk-0.7-2.fc16.src.rpm Koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3466047
[+] OK [X] NOT OKAY [-] NA [+] Package meets naming and packaging guidelines [+] Spec file matches base package name. [+] Spec has consistant macro usage. [+] Meets Packaging Guidelines. [+] License [X] License field in spec matches License is GPLv2+ ? Please check the source files [+] License file included in package [+] Spec in American English [+] Spec is legible. [+] Sources match upstream md5sum: 56d15f3b80da5780f973bf265bc6fa44 transmission-remote-gtk-0.7.tar.gz -- done [-] Package needs ExcludeArch [+] BuildRequires correct [+] Spec handles locales/find_lang [-] Package is relocatable and has a reason to be. [+] Package has %defattr and permissions on files is good. [-] Package has a correct %clean section. [-] Package has correct buildroot [+] Package is code or permissible content. [-] Doc subpackage needed/used. [-] Packages %doc files don't affect runtime. [-] Headers/static libs in -devel subpackage. [-] Spec has needed ldconfig in post and postun [-] .pc files in -devel subpackage/requires pkgconfig [-] .so files in -devel subpackage. [-] -devel package Requires: %{name} = %{version}-%{release} [-] .la files are removed. [+] Package is a GUI app and has a .desktop file [+] Package compiles and builds on at least one arch. [+] Package has no duplicate files in %files. [+] Package doesn't own any directories other packages own. [+] Package owns all the directories it creates. [+] rpmlint SHOULD Items: [+] Should build in mock. [+] Should build on all supported archs [+] Should function as described. [-] Should have sane scriptlets. [-] Should have subpackages require base package with fully versioned depend. [+] Should have dist tag [+] Should package latest version [+] check for outstanding bugs on package. (For core merge reviews) Package has following issues: License is GPLv2+ ? Please check the source files While installing rpm i am getting following error message: install-info: No such file or directory for /usr/share/info/transmission-remote-gtk.info
Done, Thanks for pointing out SPEC: http://kumarpraveen.fedorapeople.org/transmission-remote-gtk/transmission-remote-gtk.spec SRPM: http://kumarpraveen.fedorapeople.org/transmission-remote-gtk/transmission-remote-gtk-0.7-3.fc16.src.rpm
You have forgot to remove %preun if [ $1 = 0 ] ; then /sbin/install-info --delete %{_infodir}/%{name}.info %{_infodir}/dir || : fi You don't need this as you are not installing any info files in %post section. Please remove above lines in spec file and rebuild them. Because of this line i am getting following error while uninstalling "install-info: No such file or directory for /usr/share/info/transmission-remote-gtk.info" Otherwise package looks fine XXXXXX APPROVED XXXXXXXXXX
New Package SCM Request ======================= Package Name: transmission-remote-gtk Short Description: GTK remote control for the Transmission BitTorrent client Owners: kumarpraveen Branches: f15 f16
Git done (by process-git-requests).
transmission-remote-gtk-0.7-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/transmission-remote-gtk-0.7-3.fc16
transmission-remote-gtk-0.7-3.fc16 has been pushed to the Fedora 16 testing repository.
transmission-remote-gtk-0.7-3.fc16 has been pushed to the Fedora 16 stable repository.
transmission-remote-gtk-1.0.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/transmission-remote-gtk-1.0.1-1.fc16
transmission-remote-gtk-1.0.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/transmission-remote-gtk-1.0.1-1.fc15
transmission-remote-gtk-1.0.1-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.
transmission-remote-gtk-1.0.1-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.