Description of problem: In the resource group config, if a member propery value in the edit modal window is unset and user clicks on the cancel button on the modal window, the 'Save' button on the resource group config screen and the cancelled edit is saved on clicking save button. Version-Release number of selected component (if applicable): Build: JON 3.0.0.BETA3 (5c36317:550130c) Browser: Firefox 3.6.3 How reproducible: Always Steps to Reproduce: 1. Create a compatible group of resources (Ex: I created it for a single RHQ Agent) 2. Navigate to the 'Configuration->Current' tab. 3. Click on the edit icon for a property having a value (Ex: Availability Scan Initial Delay having a value 1001) 4. Click on the 'Unset' checkbox for the member value. 5. Click on the Cancel button on the modal window. 6. The 'Save' button gets enabled on the group config screen. 7. Click on the Save button. It saves the configuration which was edited and cancelled and the value for the property 'Availability Scan Initial Delay' is unset. Actual results: 'Save' button on resource group config is enabled after edit and cancel Expected results: 'Save' button should not be enabled. Additional info: 'Save' button on resource group config is not enabled after editing and cancelling a value of property like 'Availability Scan Initial Delay'. It is enabled only when user unsets the member value and clicks 'Cancel' on the modal window.
This looks related to Mazz's latest group config editor changes
Created attachment 529353 [details] cannot replicate video see attached screen capture video showing what I did. I cannot replicate this.
Created attachment 529354 [details] cannot replicate video 2 attaching new video - I forgot in my replication steps to add a value after clicking unset. This time I change the value to something. But I still can't replicate.
Tested on latest master build#595 (Version: 4.1.0-SNAPSHOT Build Number: 2662779) The bug is not reproducible on latest master. Save button remains disabled after edit, unset and cancel of group config property. However, this is reproducible on JON3 Beta3 build. Build Details: (Version: 3.0.0.BETA3 Build Number: 5c36317:550130c) (https://brewweb.devel.redhat.com//buildinfo?buildID=183867) Browser Version: Firefox 3.6.3 , FF 3.0.18 Server details where JON3 Beta3 build is installed: http://10.65.201.124:7080 Steps to Reproduce: 1. Create a compatible group of resources (Ex: RHQ Agent) 2. Navigate to the 'Configuration->Current' tab. 3. Click on the edit icon for a property having a value (Ex: Availability Scan Initial Delay having a value 1001) 4. Click on the 'Unset' checkbox for the member value. 5. Click on the Cancel button on the modal window. 6. The 'Save' button gets enabled on the group config screen. 7. Click on the Save button. It saves the configuration which was edited and cancelled and the value for the property 'Availability Scan Initial Delay' is unset.
a new JON beta build has been released. test on that to see that the fixes that went into master are now on the beta.
there is something not right with this (i don't know if the change that was in JON Beta 3 is in Master or not ... or if this is a new issue. see attached screenshot. when i set a property ... the OK button is not enabled.
Created attachment 529965 [details] OK button not enabled
(In reply to comment #6) > there is something not right with this (i don't know if the change that was in > JON Beta 3 is in Master or not ... or if this is a new issue. > > see attached screenshot. > > when i set a property ... the OK button is not enabled. you have to "save" the edited value. By this I mean, in SmartGWT, the "table cell editor" gives you the text field to edit a value. You either click outside the cell being edited or hit the enter key (I think enter works) and the value is "saved" into the cell. At that point, the OK button should be enabled. I think SmartGWT works like this because you could use the ESC key to cancel the editing (but I'm not sure about that - again, this is all SmartGWT internals, we just use the SmartGWT table-cell-editing component). I've also noticed you could actually click the OK button and that would trigger the event to save the cell value (because you clicked outside of the cell being edited) and would also send that click event to the OK button. Putting back to ON_QA to make sure this is what Mike tried. Because in the screen snapshot, I see the cell editor is still up (its a text field - which is the editor component) which tells me you didn't "confirm" or "save" the cell value into the cell. Hence, the OK button shouldn't be enabled.
(In reply to comment #8) > you have to "save" the edited value. By this I mean, in SmartGWT, the "table > cell editor" gives you the text field to edit a value. You either click outside > the cell being edited or hit the enter key (I think enter works) and the value > is "saved" into the cell. At that point, the OK button should be enabled. If you had more than one resource in the group, you can also navigate around with the up/down arrows (if there is only one resource like you have, hitting up or down arrow may work as well, dunno). Its best to try this out with multiple resources in the group (since that is more realistic anyway) and start changing their values normally. Either clicking to each cell or using the up/down arrow keys.
ok. retested. the overall usability seems a bit quirky, but it works as designed.
changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE
marking VERIFIED BZs to CLOSED/CURRENTRELEASE