Hide Forgot
Name : sablecc Version : 3.2 License : LGPLv2 URL : http://sablecc.org Summary : A parser generator written in Java Description : SableCC is a parser generator which generates object-oriented frameworks for building compilers, interpreters and other text parsers. SableCC keeps a clean separation between machine and user code which leads to a shorter development cycle. SPEC: http://downloads.eucalyptus.com/software/devel/fedora-16-gwt/SPECS/sablecc.spec SRPM: http://downloads.eucalyptus.com/software/devel/fedora-16-gwt/SRPMS/sablecc-3.2-1.fc16.src.rpm
I got this.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Rpmlint output: sablecc.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers The value of this tag appears to be misspelled. Please double-check. OK. sablecc.noarch: W: no-manual-page-for-binary sablecc Each executable in standard binary directories should have a man page. OK. [x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [!] License field in the package spec file matches the actual license. License type: [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 0c38a98fddc374e5d4b67bf4c2ff4c19 MD5SUM upstream package: 0c38a98fddc374e5d4b67bf4c2ff4c19 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates or must require other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [x] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [-] Javadoc documentation files are generated and included in -javadoc subpackage [-] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [-] Javadoc subpackages have Require: jpackage-utils [-] Package uses %global not %define [-] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [x] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) === Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [x] Reviewer should test that the package builds in mock. Tested on: === Issues === 1. License used is LGPL version 2.1 or any later version. I'm approving this, but you'll have to fix License to LGPLv2+ ================ *** APPROVED *** ================
New Package SCM Request ======================= Package Name: sablecc Short Description: A parser generator written in Java Owners: arg Branches: f16 el6 InitialCC:
Git done (by process-git-requests).