Spec URL: http://um-pe09-2.di.uminho.pt/fedora/perl-ZeroMQ.spec SRPM URL: http://um-pe09-2.di.uminho.pt/fedora/perl-ZeroMQ-0.17-1.fc15.src.rpm Description: The ZeroMQ module is a wrapper of the 0MQ message passing library for Perl. It's a thin wrapper around the C API. Please read http://zeromq.org for more details on ZeroMQ.
New upstream release: http://um-pe09-2.di.uminho.pt/fedora/perl-ZeroMQ-0.18-1.fc15.src.rpm
Review:- + koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3518307 + rpmlint on rpms gave perl-ZeroMQ.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/ZeroMQ/ZeroMQ.so ZeroMQ.so()(64bit) perl-ZeroMQ.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/ZeroMQ/ZeroMQ.so ZeroMQ.so()(64bit) 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + Source verified with upstream as (sha1sum) 4d96b2b89b57db8b1e80a6fa99d4c1d99713d5bc ZeroMQ-0.18.tar.gz 4d96b2b89b57db8b1e80a6fa99d4c1d99713d5bc ../SOURCES/ZeroMQ-0.18.tar.gz + make test All tests successful. Files=13, Tests=63, 8 wallclock secs ( 0.05 usr 0.02 sys + 0.73 cusr 0.11 csys = 0.91 CPU) + Package perl-ZeroMQ-0.18-1.fc17.x86_64 => Provides: ZeroMQ.so()(64bit) perl(ZeroMQ) = 0.18 perl(ZeroMQ::Constants) perl(ZeroMQ::Context) perl(ZeroMQ::Message) perl(ZeroMQ::Poller) perl(ZeroMQ::Raw) perl(ZeroMQ::Socket) Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) libuuid.so.1()(64bit) libzmq.so.1()(64bit) perl >= 0:5.008 perl(Carp) perl(Exporter) perl(IO::Handle) perl(Scalar::Util) perl(XSLoader) perl(ZeroMQ) perl(ZeroMQ::Constants) perl(ZeroMQ::Context) perl(ZeroMQ::Message) perl(ZeroMQ::Poller) perl(ZeroMQ::Raw) perl(ZeroMQ::Socket) perl(base) perl(strict) perl(warnings) rtld(GNU_HASH) Suggestions: 1) BR: on perl is really not needed 2) If building this on Fedora only then you don't need a) buidlroot b) cleaning of buildroot in %install c) %clean section d) defattr(-,root,root,-) 3) you don't need following explicit Requires: as they will get automatically pulled by yum Requires: perl(JSON) >= 2.00 Requires: perl(Task::Weaken) APPROVED.
New Package SCM Request ======================= Package Name: perl-ZeroMQ Short Description: ZeroMQ2 wrapper for Perl Owners: jpo Branches: F15 F16 InitialCC: perl-sig
Git done (by process-git-requests).
Parag, Thanks for the review. I've a couple of comments regarding your suggestions below: (In reply to comment #2) ---[snip]--- > > Suggestions: > 1) BR: on perl is really not needed Removed. > 2) If building this on Fedora only then you don't need > a) buidlroot > b) cleaning of buildroot in %install > c) %clean section > d) defattr(-,root,root,-) I will most likely apply these changes in a future release. Right now I'm also interested in having this perl module in the EPEL5/6 repositories (at least EPEL6), but it may prove to problematic (the Test::More version is one of the problems). > 3) you don't need following explicit Requires: as they will get automatically > pulled by yum > Requires: perl(JSON) >= 2.00 > Requires: perl(Task::Weaken) I don't think these two are pulled: 1) JSON is pulled in by a require statement and this is not caught by rpmbuild; 2) Task::Weaken needs to be explicity pulled in order to handle some (old?) Scalar::Util problems Regards, jpo
I removed perl-JSON and perl-Task-Weaken rpms using rpm command on my f16. Tried to install this package and see how it detected required dependencies Examining ../RPMS/x86_64/perl-ZeroMQ-0.18-1.fc16.x86_64.rpm: perl-ZeroMQ-0.18-1.fc16.x86_64 Marking ../RPMS/x86_64/perl-ZeroMQ-0.18-1.fc16.x86_64.rpm to be installed Resolving Dependencies --> Running transaction check ---> Package perl-ZeroMQ.x86_64 0:0.18-1.fc16 will be installed --> Processing Dependency: perl(JSON) >= 2.00 for package: perl-ZeroMQ-0.18-1.fc16.x86_64 --> Processing Dependency: perl(Task::Weaken) for package: perl-ZeroMQ-0.18-1.fc16.x86_64 --> Running transaction check ---> Package perl-JSON.noarch 0:2.53-3.fc16 will be installed ---> Package perl-Task-Weaken.noarch 0:1.02-11.fc16 will be installed --> Finished Dependency Resolution
Ah! sorry looks like you are right here. I used your spec and forgot to remove them from spec and check it.
perl-ZeroMQ-0.18-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-ZeroMQ-0.18-2.fc16
perl-ZeroMQ-0.18-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-ZeroMQ-0.18-2.fc15
perl-ZeroMQ-0.18-2.fc15 has been pushed to the Fedora 15 stable repository.
perl-ZeroMQ-0.18-2.fc16 has been pushed to the Fedora 16 stable repository.