Bug 747761 - gtk_cell_renderer_progress_set_property improperly handles "inverted" property
Summary: gtk_cell_renderer_progress_set_property improperly handles "inverted" property
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: gtk3
Version: 16
Hardware: All
OS: All
unspecified
unspecified
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-20 23:53 UTC by Vallimar
Modified: 2011-10-24 17:54 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-10-24 17:54:50 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch used with Transmission (2.05 KB, patch)
2011-10-20 23:53 UTC, Vallimar
no flags Details | Diff

Description Vallimar 2011-10-20 23:53:00 UTC
Created attachment 529406 [details]
Patch used with Transmission

Description of problem:
This problem was noticed in forward-porting the inverted cell progressbar rendering from transmission-2.33 to an updated 2.42 version compiled using gtk3. Essentially, instead of the progress bar having an inverted orientation, it switches from horizontal to vertical. Examing the code, the inverted property sets the orientation variable instead of the inverted variable. The orientation property in gtk3 is an enum that only has horizontal and vertical as options, unlike in gtk2.

Version-Release number of selected component (if applicable):
Tested 3.2.1, may affect all 3.x versions

How reproducible:
Always

Steps to Reproduce:
1. Set "inverted" property using g_object_set, to true (see attached)
2. Compile
3. Run
  
Actual results:
Cell progress bars when seeding change orientation to vertical instead of right-to-left

Expected results:
Cell progress bars when seeding should display right-to-left, instead of left-to-right as when downloading.

Additional info:
Recompiling gtk3-3.2.1-1 with this patch fixes the problem for me.

--- a/gtk/gtkcellrendererprogress.c
+++ b/gtk/gtkcellrendererprogress.c
@@ -355,7 +355,7 @@ gtk_cell_renderer_progress_set_property
       priv->orientation = g_value_get_enum (value);
       break;
     case PROP_INVERTED:
-      priv->orientation = g_value_get_boolean (value);
+      priv->inverted = g_value_get_boolean (value);
       break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, param_id, pspec);

Comment 1 Matthias Clasen 2011-10-24 17:54:50 UTC
Thanks, fixed upstream.


Note You need to log in before you can comment on or make changes to this bug.