Bug 749055 (libkactivities) - Review Request: libkactivities - API for using and interacting with Activities
Summary: Review Request: libkactivities - API for using and interacting with Activities
Keywords:
Status: CLOSED RAWHIDE
Alias: libkactivities
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2011-10-26 00:10 UTC by Rex Dieter
Modified: 2011-11-04 15:01 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-11-04 15:01:25 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2011-10-26 00:10:34 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/libkactivities/libkactivities.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/libkactivities/libkactivities-6.1-1.fc16.src.rpm
Description: 
API for using and interacting with Activities as a consumer,
application adding information to them or as an activity manager.


First step and dependency for bringing Plasma Active to fedora.  Once imported, will require modifications to kdelibs, kdebase-runtime to omit their copies of libkactivities and activitymanager, respectively.

Comment 1 Jaroslav Reznik 2011-11-02 16:58:35 UTC
Name: ok
Summary: ok
Release: ok
Version: ok
License: not ok, GPLv2+ and LGPLv2+ (actual library) and (CC-BY or BSD) for ontology
URL: ok
Sources: ok (md5sum d69d42e8521c4a7c01991222572c2cab)
BRs: ok
Requires: ok
Conflicts: ok
Description: ok

Devel subpackage: ok

Macros used consistently: ok
Ldconfig usage: ok
Uses smpflags: ok

No docs/license file provided, contact upstream to fix it (actually I promised it, so I should go through all packages and report it, during BDS).

Files: ok
So in -devel: ok

rpmlint libkactivities-6.1-1.fc16.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Package builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=3480646 ok

Please fix the license issue, otherwise package is ok.

Comment 2 Rex Dieter 2011-11-02 19:45:15 UTC
I'm not sure I agree with any license that's not marked GPLv2+ here.  Sure, there are some sources that are LGPLv2+, GPLv2+, but the aggregate license of those combined sources for both the library and activitymanager pieces ends up being GPLv2+

The ontologies are fun too, only used during the build process (via onto2vocabularyclass too) to generate some sources/headers, but each of those generated files are clearly marked LGPLv2+

Comment 3 Jaroslav Reznik 2011-11-03 11:42:28 UTC
(In reply to comment #2)
> I'm not sure I agree with any license that's not marked GPLv2+ here.  Sure,
> there are some sources that are LGPLv2+, GPLv2+, but the aggregate license of
> those combined sources for both the library and activitymanager pieces ends up
> being GPLv2+

What I remember we agreed on not using aggregated licenses, didn't we? It's just reminder, if we do not want to follow it, then it's ok for me to approve this. one.

> The ontologies are fun too, only used during the build process (via
> onto2vocabularyclass too) to generate some sources/headers, but each of those
> generated files are clearly marked LGPLv2+

Ok, makes sense.

Comment 4 Rex Dieter 2011-11-04 13:52:12 UTC
Meh, we can sort out the licensing details later... :)

%changelog
* Fri Nov 04 2011 Rex Dieter <rdieter>  6.1 -2
- License: GPLv2+ and LGPLv2+


Spec URL:
http://rdieter.fedorapeople.org/rpms/libkactivities/libkactivities.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/libkactivities/libkactivities-6.1-1.fc16.src.rpm

Comment 5 Jaroslav Reznik 2011-11-04 14:10:43 UTC
Ok, 
thanks Rex.

APPROVED

Comment 6 Rex Dieter 2011-11-04 14:16:27 UTC
New Package SCM Request
=======================
Package Name: libkactivities
Short Description: API for using and interacting with Activities
Owners: than jreznik kkolfer ltinkl rdieter rnovacek
Branches: f16
InitialCC:

Comment 7 Gwyn Ciesla 2011-11-04 14:18:51 UTC
Git done (by process-git-requests).

Dropped kkolfer, not a valid FAS account.

Comment 8 Rex Dieter 2011-11-04 15:01:25 UTC
Sorry for the typo.

Imported.


Note You need to log in before you can comment on or make changes to this bug.