Red Hat Bugzilla – Bug 749195
[PATCH] nfs-utils-1.2.5-2.fc16 fails to build, PAGE_SIZE undefined
Last modified: 2012-03-14 09:10:19 EDT
Created attachment 530281 [details]
fix for undefined PAGE_SIZE
Description of problem:
ppc and ppc64 don't have PAGE_SIZE defined in the glibc headers, so nfs-utils fails to build:
Version-Release number of selected component (if applicable):
nfs-utils-1.2.5-2.fc16 and nfs-utils-1.2.5-1.fc16
Steps to Reproduce:
1. ppc-koji build --scratch dist-f16 nfs-utils-1.2.5-2.fc16.src.rpm
It appears glibc-headers was removed from the default build root...
Instead the patch that adds the define, wouldn't be simpler
and better to add glibc-headers to the BuildRequires list?
no, root.log of http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=306011 has this:
DEBUG util.py:247: glibc ppc 2.14.90-13 build 4.6 M
DEBUG util.py:247: glibc-common ppc 2.14.90-13 build 11 M
DEBUG util.py:247: glibc-devel ppc 2.14.90-13 build 989 k
DEBUG util.py:247: glibc-headers ppc 2.14.90-13 build 602 k
(The root.log is from PPC, but I've reproduced this on PPC64)
Why is PAGE_SIZE not defined in the glibc headers on those arches? I'd imagine that that would break a lot of code, not just nfs-utils...
searching on ppc64:
/usr/include/common.h:#define PAGE_SIZE 4096
re: comment #4: neither nfs-utils nor any of its build requirements pull in librtas-devel (which provides /usr/include/common.h). In addition common.h doesn't get included and has a wrong value on ppc where we have a 64k pagesize.
re: comment #3: actually there only a few packages (<5) that use PAGE_SIZE instead of getpagesize(), at least that's my impression after rebuilding > 10000 packages on ppc.
This appears to be fixed in nfs-utils-1.2.5-3.fc16 which has been pushed to stable.
(In reply to comment #6)
> This appears to be fixed in nfs-utils-1.2.5-3.fc16 which has been pushed to
The latest nfs-utils version does indeed build: