Bug 749718 - RFE: UI to enable setting empty graphics password
Summary: RFE: UI to enable setting empty graphics password
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-10-28 03:06 UTC by Huming Jiang
Modified: 2014-07-06 19:31 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-17 14:08:19 UTC
Embargoed:


Attachments (Terms of Use)

Description Huming Jiang 2011-10-28 03:06:34 UTC
Description of problem:
Could not update spice/vnc password to empty for live domain. I think it should take effect to update spice/vnc password from "aabb" to empty for live domain.If virt-manager does not support to change the password to empty, when click 'Apply', it should not succeed.

Version-Release number of selected component (if applicable):
kernel-2.6.32-207.el6.x86_64
qemu-kvm-0.12.1.2-2.196.el6.x86_64
libvirt-0.9.4-19.el6.x86_64
python-virtinst-0.600.0-5.el6.noarch
virt-manager-0.9.0-7.el6.x86_64
virt-viewer-0.4.1-7.el6.x86_64

How reproducible:
always

Steps to Reproduce:

Update vnc password for live domain:

1. Open virt-manager, run a guest successfully with vnc password is "aabb"

2. Open guest details page, click Display VNC, Modify the vnc password to empty. Apply

3. Close the original guest windows, connect guest windows again.
   # virt-viewer <guestname>
   Or quit the whole virt-manager first, then launch virt-manager again, and open the guest details, the password will be informed to fill in.

4. use virt-viewer <guestname>: don't input password, because we changed our password to empty. Then click OK. Password is also "ccdd", did not change.(NOT expected.)
   use virt-manager, don't input password, because we changed our password to empty.Then click "Login",then console shows an error:
   "Error: viewer connection to hypervisor host got refused or disconnected!"(NOT expected.Password should be allowed to input again.It is different with spice graphics.)

Update spice password for live domain:

Steps are same with step 1,2,3 above.

In step4:

use virt-viewer <guestname>: don't input password, because we changed our password to empty. Then click OK. Password is also "ccdd", did not change.(NOT expected.)

   use virt-manager: don't input password, because we changed our password to empty.Then click "Login",then console suggests you to input again. Password is also "ccdd", did not change.(NOT expected.)
  
Actual results:
see above.
Expected results:
see above.

Additional info:

Comment 2 Huming Jiang 2011-10-28 03:29:30 UTC
It is confused that we could update password from empty to "aabb" for live domain, but could not update password from "aabb" to empty for live domain.

Comment 3 Cole Robinson 2011-12-09 21:45:58 UTC
Not urgent, and given reduced capacity for virt-manager/virtinst, just moving this to the upstream tracker.

I suspect this might be a qemu issue, does invoking the equivalent virsh update-device command also not work? You can check the virt-manager log to see what XML virt-manager is using

Comment 4 Cole Robinson 2012-01-30 02:59:01 UTC
Actually I think the problem is virt-manager just doesn't have any way to set an empty password. We probably want to disable the password field with a checkbox, if the box is enabled but the entry is empty, set an empty password.

Comment 5 Cole Robinson 2013-08-17 14:08:19 UTC
Fixed upstream now


Note You need to log in before you can comment on or make changes to this bug.