Bug 749890 - Mask passwords from xmlrpc tracebacks
Summary: Mask passwords from xmlrpc tracebacks
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite 5
Classification: Red Hat
Component: Server
Version: 541
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Pazdziora (Red Hat)
QA Contact: Dimitar Yordanov
URL:
Whiteboard:
Depends On:
Blocks: sat541-triage 695282 CVE-2012-0059
TreeView+ depends on / blocked
 
Reported: 2011-10-28 19:35 UTC by Christopher J Suleski
Modified: 2018-11-14 10:34 UTC (History)
4 users (show)

Fixed In Version: spacewalk-backend-1.2.13-64
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-06 18:17:16 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0101 0 normal SHIPPED_LIVE Low: Red Hat Network Satellite spacewalk-backend security and bug fix update 2012-02-06 23:15:41 UTC

Description Christopher J Suleski 2011-10-28 19:35:27 UTC
Description of problem:
Tracebacks triggered by a failure of xmlrpc/registration.py include all of the submitted data--including the user's password in clear text. This should be masked so that the password is not exposed in the logs or email.

Version-Release number of selected component (if applicable):
spacewalk-backend-xmlrpc-1.2.13-55.el5sat

How reproducible:
Always

Steps to Reproduce:
1. Use an unsupported option during the rhn registration, in this case we use "rhnreg_ks --subscription=xxxx"
2. The unknown attribute triggers a traceback to the log and email.
  
Actual results:
The traceback includes all the data from the registration, including the registering user's password in plain text.

Expected results:
The password should never be exposed.

Additional info:
Full reproducer traceback attached.

Comment 3 Jan Pazdziora (Red Hat) 2012-01-10 10:18:25 UTC
Fixed in Spacewalk master, 76d0064693107148e4a949fc7ad62d72bb3ec26c.

Also reverted change for bug 695282 in Spacewalk.

Comment 4 Miroslav Suchý 2012-01-11 10:21:38 UTC
*** Bug 695282 has been marked as a duplicate of this bug. ***

Comment 5 Jan Pazdziora (Red Hat) 2012-01-17 08:09:52 UTC
Cherry picked to SATELLITE-5.4, 3a62d545541d5509786a5e4976527180b114f324.

Tagged and built as spacewalk-backend-1.2.13-64.

Comment 8 errata-xmlrpc 2012-02-06 18:17:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0101.html


Note You need to log in before you can comment on or make changes to this bug.