Red Hat Bugzilla – Bug 750898
Review Request: icaro - A robot automation language
Last modified: 2013-10-19 10:42:52 EDT
Spec URL: http://lletelier.fedorapeople.org/icaro/icaro.spec SRPM URL: http://lletelier.fedorapeople.org/icaro/icaro-0.6.2-1.290311.fc15.src.rpm Description: Icaro is a software developed with the intention of bringing, in a manner transparent to the user the basics of programming (iterations, repetition, recursion, if conditional) of a physical context such as a robot or automation system.
Changes & updates: SPEC url: http://lletelier.fedorapeople.org/icaro/icaro.spec SRPM url: http://lletelier.fedorapeople.org/icaro/icaro-0.6.3-140811.fc15.src.rpm RPM x86_64 url: http://lletelier.fedorapeople.org/icaro/icaro-0.6.3-140811.fc15.x86_64.rpm rpmlint: http://lletelier.fedorapeople.org/icaro/icaro-0.6.3-140811.txt Thanks, --LL
I'll review it (and will sponsor you).
Thanks Peter, -- LL
Created attachment 569080 [details] adds missing include header
Few notes. * The package fails to build on non-x86 arches due to lack of <sys/io.h>. Please add "ExclusiveArch: %{ix86} x86_64" for now. I think it's a good idea to add check for this and for some other required files to the configure.ac but that's not related to the packaging and won't block the review process - that's just my friendly advice. * The package fails to build due to the missing include file - <unistd.h>. Please see patch attached. http://koji.fedoraproject.org/koji/taskinfo?taskID=3877160 Btw what's your FAS name?
(In reply to comment #2) > I'll review it (and will sponsor you). AFAIK LL is already sponsored, he just need to be reviewed.
2 nits: * %release is poorly chosen. It needs to contain a fedora specific release number. You are trying to reuse some upstream release number, which doesn't leave the fedora package maintainer an option to increment it. * Please move the "chmod -x" from %build into %prep.
*** This bug has been marked as a duplicate of bug 912930 ***