Bug 751064 - Review Request: apache-commons-lang3 - Provides a host of helper utilities for the java.lang API
Summary: Review Request: apache-commons-lang3 - Provides a host of helper utilities fo...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alexander Kurtakov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 751070
TreeView+ depends on / blocked
 
Reported: 2011-11-03 12:09 UTC by Stanislav Ochotnicky
Modified: 2011-11-07 17:20 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-07 17:20:29 UTC
Type: ---
akurtako: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Stanislav Ochotnicky 2011-11-03 12:09:06 UTC
Spec URL: http://sochotni.fedorapeople.org/packages/apache-commons-lang3.spec
SRPM URL: http://sochotni.fedorapeople.org/packages/apache-commons-lang3-3.0.1-1.fc15.src.rpm
Description: 

The standard Java libraries fail to provide enough methods for
manipulation of its core classes. The Commons Lang Component provides
these extra methods.
The Commons Lang Component provides a host of helper utilities for the
java.lang API, notably String manipulation methods, basic numerical
methods, object reflection, creation and serialization, and System
properties. Additionally it contains an inheritable enum type, an
exception structure that supports multiple types of nested-Exceptions
and a series of utilities dedicated to help with building methods, such
as hashCode, toString and equals.

With version of commons-lang 3.x, developers decided to change API and
therefore created differently named artifact and jar files. This is
the new version, while apache-commons-lang is the compatibility package

Comment 1 Alexander Kurtakov 2011-11-07 14:20:39 UTC
I would do this one.

Comment 2 Alexander Kurtakov 2011-11-07 15:10:24 UTC
Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Rpmlint output:
apache-commons-lang3.noarch: W: spelling-error Summary(en_US) lang -> Lang, lag, slang
apache-commons-lang3.noarch: W: spelling-error %description -l en_US lang -> Lang, lag, slang
apache-commons-lang3.noarch: W: spelling-error %description -l en_US enum -> menu, en um, en-um
apache-commons-lang3.noarch: W: spelling-error %description -l en_US hashCode -> hash Code, hash-code, asphodel
apache-commons-lang3.noarch: W: spelling-error %description -l en_US toString -> to String, to-string, stringing
2 packages and 0 specfiles checked; 0 errors, 5 warnings.
Not really spelling errors.OK
[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type:ASL 2.0
[x]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided in the spec URL.
MD5SUM this package    :6d39fa5eceaabc46f0a088cdc305c4d6
MD5SUM upstream package:6d39fa5eceaabc46f0a088cdc305c4d6
[x]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates or must require other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing)
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[-]  If source tarball includes bundled jar/class files these need to be removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.


APPROVED

Comment 3 Stanislav Ochotnicky 2011-11-07 15:56:54 UTC
Thanks for reviewing this

New Package SCM Request
=======================
Package Name: apache-commons-lang3
Short Description: Provides a host of helper utilities for the java.lang API
Owners: sochotni
Branches: 
InitialCC: java-sig

Comment 4 Gwyn Ciesla 2011-11-07 16:02:02 UTC
Git done (by process-git-requests).

Comment 5 Stanislav Ochotnicky 2011-11-07 17:20:29 UTC
Package build. Thanks for fast repo creation.

http://koji.fedoraproject.org/koji/taskinfo?taskID=3495020


Note You need to log in before you can comment on or make changes to this bug.