Bug 751522 - Review Request: perl-DateTime-TimeZone-SystemV - System V and POSIX timezone strings
Summary: Review Request: perl-DateTime-TimeZone-SystemV - System V and POSIX timezone ...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/DateTime-...
Depends On:
TreeView+ depends on / blocked
Reported: 2011-11-05 07:15 UTC by Iain Arnell
Modified: 2011-11-25 02:15 UTC (History)
3 users (show)

Fixed In Version: perl-DateTime-TimeZone-SystemV-0.005-1.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-11-25 01:55:20 UTC
Type: ---
emmanuel: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Iain Arnell 2011-11-05 07:15:56 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-DateTime-TimeZone-SystemV.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-DateTime-TimeZone-SystemV-0.005-1.fc17.src.rpm

An instance of this class represents a timezone that was specified by means
of a System V timezone recipe or the POSIX extended form of the same
syntax. These can express a plain offset from Universal Time, or a system
of two offsets (standard and daylight saving time) switching on a yearly
cycle according to certain types of rule.

This class implements the DateTime::TimeZone interface, so that its instances
can be used with DateTime objects.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3490575


Comment 1 Emmanuel Seyman 2011-11-06 22:44:03 UTC

Comment 2 Emmanuel Seyman 2011-11-06 22:59:49 UTC
=== KEY ===

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated


 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3492882

 [x] Rpmlint output:
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
None specified, default used.

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
1739214f1c665110ba163fb7a873bcbf  DateTime-TimeZone-SystemV-0.005.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [x] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
 [x] Package does not own files or directories owned by other packages.


 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [x] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: fedora-rawhide-x86_64
 [x] Package should compile and build into binary rpms on all supported
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3492882
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=6, Tests=725,  1 wallclock secs ( 0.11 usr  0.02 sys +  0.66 cusr  0.03 csys =  0.82 CPU)
Result: PASS

I'm not very comfortable with %{perl_vendorlib}/* in the files stanza and would prefer %{vendor_perl}/DateTime but I'm not going to block the review on this.


Comment 3 Iain Arnell 2011-11-07 04:03:41 UTC
New Package SCM Request
Package Name: perl-DateTime-TimeZone-SystemV
Short Description: System V and POSIX timezone strings
Owners: iarnell
Branches: f15 f16
InitialCC: perl-sig

Comment 4 Iain Arnell 2011-11-07 04:07:59 UTC
(In reply to comment #2)
> I'm not very comfortable with %{perl_vendorlib}/* in the files stanza and would
> prefer %{vendor_perl}/DateTime but I'm not going to block the review on this.

That's new. Did I miss some discussion on this? I've always had %{perl_vendorlib}/* in files.


Thanks for the review.

Comment 5 Gwyn Ciesla 2011-11-07 13:29:25 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2011-11-07 15:48:52 UTC
perl-DateTime-TimeZone-SystemV-0.005-1.fc16 has been submitted as an update for Fedora 16.

Comment 7 Fedora Update System 2011-11-07 15:49:02 UTC
perl-DateTime-TimeZone-SystemV-0.005-1.fc15 has been submitted as an update for Fedora 15.

Comment 8 Fedora Update System 2011-11-10 17:38:14 UTC
perl-DateTime-TimeZone-SystemV-0.005-1.fc16 has been pushed to the Fedora 16 testing repository.

Comment 9 Fedora Update System 2011-11-25 01:55:20 UTC
perl-DateTime-TimeZone-SystemV-0.005-1.fc16 has been pushed to the Fedora 16 stable repository.

Comment 10 Fedora Update System 2011-11-25 02:15:20 UTC
perl-DateTime-TimeZone-SystemV-0.005-1.fc15 has been pushed to the Fedora 15 stable repository.

Note You need to log in before you can comment on or make changes to this bug.