Spec URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-Has-Sugar.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-Has-Sugar-0.05070419-1.fc17.src.rpm Description: SYNOPSIS Moose "has" syntax is generally fine, but sometimes one gets bothered with the constant typing of string quotes for things. The MooseX::Types module exists and in many ways reduces the need for constant string creation. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3490627 *rt-0.10_02
Oops. The summary and description were a bit lame. Fixed in this build. Spec URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-Has-Sugar.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-Has-Sugar-0.05070419-2.fc17.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3490631
$ rpmlint -i -v *perl-MooseX-Has-Sugar.noarch: I: checking perl-MooseX-Has-Sugar.noarch: I: checking-url http://search.cpan.org/dist/MooseX-Has-Sugar/ (timeout 10 seconds) perl-MooseX-Has-Sugar.noarch: E: incorrect-fsf-address /usr/share/doc/perl-MooseX-Has-Sugar-0.05070419/LICENSE The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. perl-MooseX-Has-Sugar.src: I: checking perl-MooseX-Has-Sugar.src: I: checking-url http://search.cpan.org/dist/MooseX-Has-Sugar/ (timeout 10 seconds) perl-MooseX-Has-Sugar.src: I: checking-url http://www.cpan.org/authors/id/K/KE/KENTNL/MooseX-Has-Sugar-0.05070419.tar.gz (timeout 10 seconds) perl-MooseX-Has-Sugar.spec: I: checking-url http://www.cpan.org/authors/id/K/KE/KENTNL/MooseX-Has-Sugar-0.05070419.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 1 errors, 0 warnings. An old FSF once again. Should be reported to the upstream developers. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPL+ or Artistic [+] MUST: The License field in the package spec file must match the actual license. [.] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 4208e85e65b568707e91b45552347b44 MooseX-Has-Sugar-0.05070419.tar.gz 4208e85e65b568707e91b45552347b44 MooseX-Has-Sugar-0.05070419.tar.gz.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. Don't know how to test it on my system. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [+] SHOULD: Your package should contain man pages for binaries/scripts. ---------------- PACKAGE APPROVED ----------------
New Package SCM Request ======================= Package Name: perl-MooseX-Has-Sugar Short Description: Sugar syntax for moose 'has' fields Owners: iarnell Branches: f15 f16 InitialCC: perl-sig
(In reply to comment #2) > > An old FSF once again. Should be reported to the upstream developers. This is rapidly becoming the most annoying rpmlint "error". Upstream is using Dist-Zilla, so should automatically have the updated license with the next release. > PACKAGE APPROVED Thanks for the review.
Git done (by process-git-requests).
perl-MooseX-Has-Sugar-0.05070419-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-MooseX-Has-Sugar-0.05070419-2.fc16
perl-MooseX-Has-Sugar-0.05070419-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-MooseX-Has-Sugar-0.05070419-2.fc15
perl-MooseX-Has-Sugar-0.05070419-2.fc16 has been pushed to the Fedora 16 testing repository.
perl-MooseX-Has-Sugar-0.05070419-2.fc15 has been pushed to the Fedora 15 stable repository.
perl-MooseX-Has-Sugar-0.05070419-2.fc16 has been pushed to the Fedora 16 stable repository.