Bug 7522 - Annoyances in nethack package, fixes available.
Summary: Annoyances in nethack package, fixes available.
Alias: None
Product: Red Hat Powertools
Classification: Retired
Component: nethack
Version: 6.1
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Tim Powers
QA Contact:
Depends On:
TreeView+ depends on / blocked
Reported: 1999-12-02 22:48 UTC by Alan Shutko
Modified: 2008-05-01 15:37 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2000-01-13 01:25:45 UTC

Attachments (Terms of Use)
New spec file (3.01 KB, text/plain)
1999-12-03 03:33 UTC, Alan Shutko
no flags Details
My (combined) patch. I can split it if desired. (15.94 KB, patch)
1999-12-03 03:34 UTC, Alan Shutko
no flags Details | Diff

Description Alan Shutko 1999-12-02 22:48:28 UTC
I disliked a bunch of stuff with the default powertools nethack compile.
Biggest glitch was the chown in the %post which made verifying it always
complain.  I also disliked the permissions on everything.  Now it is sgid,
as seems to be recommended.  While I was at it, I changed things to compile
as SYSV instead of BSD, since it's really closer.

I have a new patch and a new spec file, and I'll send them in as soon as I
figure out how to attach it to this bug.

Comment 1 Alan Shutko 1999-12-03 03:33:59 UTC
Created attachment 20 [details]
New spec file

Comment 2 Alan Shutko 1999-12-03 03:34:59 UTC
Created attachment 21 [details]
My (combined) patch.  I can split it if desired.

Comment 3 Tim Powers 1999-12-13 15:27:59 UTC
Thanks. I'll  see just how much of this I can incorporate into nethack 3.3.0
which was just released.


Comment 4 Tim Powers 1999-12-13 15:46:59 UTC
Actually, if you have already worked on spec and patch for the 3.3.0 sources it
could help speed things up quite a bit, especially since you use nethack and I
don't :)


Comment 5 Alan Shutko 1999-12-13 15:51:59 UTC
I've reworked and am using a new spec and patch on NH 3.3.0, but I'm seeing a
glitch in the color handling on xterminals.  I see the same problem on their
compiled binary, but I'm not sure I want to spread the RPM until the bug is
corrected (not knowing if it's a compilation bug, or if they broke something).

Let me play with it another day or so, and I'll put the patch and spec here.  By
then, I should be satisfied as to whether it's their problem or my problem.

Comment 6 Alan Shutko 1999-12-13 15:57:59 UTC
Whee!  Just discovered it isn't my fault.  I'll go attach the spec and patch
now... feel free to modify the spec, since I'm quite new at modifying them.
FWIW, NH 3.3.0 has a bug in displaying colors when the terminfo entry doesn't
list them... must dig in and look at it.

Attaching, attaching... well, at least I will when I can figure out how on an
existing bug....

Comment 7 Tim Powers 1999-12-13 16:05:59 UTC
Just a tip for generating patches, it amkes things easier for us to incorporate
and also is a bit cleaner :)

Go to the pristine source dir, copy the origional files you are going to change
to their filename.suffix. For example if I have to make changes to config.h I
would do this:

	cp config.h config.h.tim

Now edit the origional filename (the one without the new suffix).

Once you are done cd above the top level dir for the package, lets say in this
case nethack-3.3.0, you want to be above that dir, now do this:

gendiff nethack-3.3.0 .tim > nethack.patch

What this does is runs gendiff to look into nethack-3.3.0 where the origional
files are suffixed with .tim, redirect the output to > nethack.patch. Voila, now
there's a patch which we can use without modification :)

Thought that I might let you knwo about this one. I hope it helps some, I do
know that it helps us :)


Note You need to log in before you can comment on or make changes to this bug.