Hide Forgot
Spec URL: http://pingou.fedorapeople.org/RPMs/python-straight.plugin.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/python-straight.plugin-1.1.1-1.57ef11c.fc16.src.rpm Description: straight.plugin is a Python plugin loader inspired by twisted.plugin with two important distinctions: - Fewer dependencies - Python 3 compatible The system is used to allow multiple Python packages to provide plugins within a namespace package, where other packages will locate and utilize. The plugins themselves are modules in a namespace package where the namespace identifies the plugins in it for some particular purpose or intent.
Talked on IRC and spec file has been updated. This review is based on the tarball from the srpm and the new spec file rpmlint: python-straight.plugin.noarch: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging [snip other spelling warnings] These are all false positives -- the words are common in computing. python-straight.plugin.src: W: invalid-url Source0: ironfroggy-straight.plugin-57ef11c.tar.gz There is a comment above the Source0 explaining how to retrieve the tarball from github so this is fine. Good: * License is BSD in source and spec * LICENSE file included * Spec file is legible * Sources match with upstream by following the github url to get the snapshot. * Package builds in koji for f16 * No localized files so no i18n concerns * Not a shared library package so no concerns there * No bundled libraries * Package owns the directories it creates and nothing more * Files listed once in the %files section * File permissions are correct * Macros used consistently * Code, not content * No large documentation files * Documentation is not used at runtime * Not a GUI app * No supbackages * All filenames are valid utf-8 Needswork: * Naming guidelines want "." replaced with "-" so this should be named python-straight-plugin. (and spec file renamed to match). Cosmetic: * Could BuildRequire: python2-devel instead of python-devel * The description says python3 compatible but you aren't building a python3 subpackage. I'd either build the subpackage or remove that line from the description. Fix the naming and I'll approve this.
Thanks for your comments (here and on irc) and the review. I changed the name and added a python3 sub-package. I used 2to3 to generate the sub-package although it seems unnecessary but for the future, better safe than sorry. Spec URL: http://pingou.fedorapeople.org/RPMs/python-straight-plugin.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/python-straight-plugin-1.1.1-0.2.20111110git57ef11c.fc16.src.rpm
There is the new version with the correct use of %{__python3} on the build and test Spec URL: http://pingou.fedorapeople.org/RPMs/python-straight-plugin.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/python-straight-plugin-1.1.1-0.3.20111110git57ef11c.fc16.src.rpm
All problems have been fixed. APPROVED.
New Package SCM Request ======================= Package Name: python-straight-plugin Short Description: Python plugin loader Owners: pingou sochotnicky Branches: f15 f16 el6
Fix Stanislav's FAS username New Package SCM Request ======================= Package Name: python-straight-plugin Short Description: Python plugin loader Owners: pingou sochotni Branches: f15 f16 el6
Git done (by process-git-requests).
python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.fc15
python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.fc16
python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.el6
python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.el6 has been pushed to the Fedora EPEL 6 testing repository.
python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.fc15 has been pushed to the Fedora 15 stable repository.
python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.fc16 has been pushed to the Fedora 16 stable repository.
python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.el6 has been pushed to the Fedora EPEL 6 stable repository.
Package Change Request ====================== Package Name: python-straight-plugin New Branches: epel7 Owners: pingou
Thanks @Till!