Bug 753918 - external.sh test failed when build in mock
Summary: external.sh test failed when build in mock
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: darcs
Version: el6
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-14 20:58 UTC by Giam Teck Choon
Modified: 2012-06-02 06:35 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-06-02 06:32:18 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
This patch is to disable external.sh and exit with 200 (440 bytes, patch)
2011-11-14 20:59 UTC, Giam Teck Choon
no flags Details | Diff

Description Giam Teck Choon 2011-11-14 20:58:35 UTC
Description of problem:

Reference: http://us.generation-nt.com/answer/bug-596606-darcs-fails-build-without-network-connectivity-help-200279511.html

When trying to rebuild darcs in mock, it will fail with the following partial log:

Running whatsnew-file.sh ...                     passed.
Running whatsnew.sh ...                          passed.
Running workingdir.sh ...                        passed.
Some tests failed:
external.sh
Setup: Tests failed
error: Bad exit status from /var/tmp/rpm-tmp.iKljMO (%check)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.iKljMO (%check)


Version-Release number of selected component (if applicable):
darcs-2.4.4-3.el6


Patch attached to disable external.sh test which in result in successful build of darcs-2.4.4-3.el6.

Thanks.

Kindest regards,
Giam Teck Choon

Comment 1 Giam Teck Choon 2011-11-14 20:59:48 UTC
Created attachment 533620 [details]
This patch is to disable external.sh and exit with 200

Comment 2 Jens Petersen 2011-11-16 01:06:57 UTC
Hmm I wonder how this test passed in koji:

http://koji.fedoraproject.org/koji/buildinfo?buildID=198918

Comment 3 Jens Petersen 2012-01-26 03:44:18 UTC
I wonder how it is failing exactly - external.sh shouldn't need a network
connection anyway.  I don't know if you can run the test in your
mock root?

I guess your builtroot is more restrictive in packages than
the Fedora defaults.

Comment 4 Giam Teck Choon 2012-02-04 19:48:44 UTC
Sorry for this late reply.  May I know how you want me to test?

Here are the list about the Requires packages for my buildroot:

bash
buildsys-macros
bzip2
cpio
diffutils
gcc
gcc-c++
gzip
make
patch
perl
rpm-build
sed
tar
unzip
which
redhat-release
coreutils
elfutils
redhat-rpm-config
shadow-utils

Comment 5 Jens Petersen 2012-02-06 06:13:14 UTC
I see thanks, interesting.

You can compare that to what is in the koji buildroot:
http://kojipkgs.fedoraproject.org/packages/darcs/2.4.4/3.el6/data/logs/x86_64/root.log

Okay now I finally understood your suggested patch is already in Debian...

I believe external network access does not work from mock/koji
and I think the test in question is probably only using internal network
access perhaps to 127.0.0.1(?) and hence succeeds.  Given that it doesn't
cause problems for fedora or epel then I prefer not to disable the test
unnecessarily unless there is a stronger reason to do so.

Thank you reporting this issue anyway.

Comment 6 Jens Petersen 2012-06-02 06:32:18 UTC
Well I am going to close this out for now.

If you still feel this is a serious problem
then feel free to re-open.  Thanks for your report.

Comment 7 Jens Petersen 2012-06-02 06:35:58 UTC
I just note in passing that darcs-2.5.2 for epel6 is in testing now.
I don't know if it helps with this issue at all.
Actually I guess it does since for 2.5.2 I turned
off the testsuite for ghc7.  I suppose I could have
slyly closed this when the ghc7 packages go to stable. ;) :)


Note You need to log in before you can comment on or make changes to this bug.