This is just a first version of the package, since I know, that there is a lot to do. I just started this review request, in order to see, if there is somethine speaking against this package (forbidden items or so), because it's just my third package I build.
I also need a sponsor ;).
- check the package (no rpmlint or mock has been done yet)
- desktop file
I would like to see, if there are some legal concerns, or if I can go on :D!
Well you made your life rather easy but unfortunately what you are doing is packaging prebuilt binaries that are built with provided libs instead of building against fedora provided libraries with the fedora provided java.
* package the src zip (upstream provides one)
* remove lib/*
* patch the build.xml or create symlinks to the appropriate libraries in lib/
* build it with ant
* package the results in a working manner
thanks for your effort in getting that nice application into the distribution.
Blocking FE-Legal to get the legal opinion requested in the description of the bug.
I'm not exactly sure what legal concerns there are here. I haven't looked at the source code at all, but from the TV-Browser website, it seems to be acceptable for Fedora (they secure permission before providing listing information).
Obviously, it needs to be built from source, have any bundled jars removed, and be under acceptable Free Software licenses, but that's no different from any other Fedora package. Lifting FE-Legal.
(In reply to comment #1)
> * package the src zip (upstream provides one)
> * remove lib/*
> * patch the build.xml or create symlinks to the appropriate libraries in lib/
> * build it with ant
> * package the results in a working manner
So I have removed the lib/* directory, but I don't know, how to go on, because inside the lib/* directory are some files, that I couldn't find in the standard fedora setup (/usr/share/java).
Could someone please help me?
*** Bug 472144 has been marked as a duplicate of this bug. ***
(In reply to comment #5)
> *** Bug 472144 has been marked as a duplicate of this bug. ***
Thanks, this helps me a bit. Now I could go a step further.
Trying to build all the libs, I get the following output by some:
/usr/bin/build-jar-repository: error: Could not find jakarta-commons-codec Java extension for this JVM
/usr/bin/build-jar-repository: error: Could not find jakarta-commons-lang Java extension for this JVM
/usr/bin/build-jar-repository: error: Could not find jakarta-commons-net Java extension for this JVM
/usr/bin/build-jar-repository: error: Could not find jakarta-commons-compress Java extension for this JVM
/usr/bin/build-jar-repository: error: Some specified jars were not found for this jvm
I couldn't find for example "jakarta-commons-codec" in the repository. Isn't it available anymore? How should I go on?
Greets from germany
i habe been able to find almost everything to build the /lib/* directory, but what I couldn't find is: substance.
Does anyone know, if there is a package for this GUI Framework?!
Would be fine if I got some help ;).
seems like we can close this review request, since TV-Browser needs Java Substance and I have no idea, how I should get this into fedora.
i am still busy this and next week but then i have time and i am willing to help you to get this software built correctly because i think it would be a nice addition to fedora. is there any way to contact you? are you on freenode irc?
Thanks for your help ;). I'm curently working on the substance package as you might see :D. The best way to contact me is by mail, because currently I'm a bit full with work and also in private life. Also I'm available via ICQ, if this would be an option.
Just a comment: The name of this package could be tvbrowser instead of Tv-Browser.
sven could you please publish your latest spec file + patches (if needed) so i can take a closer look? sorry for the delays, but i have been rather busy.
(In reply to comment #12)
> sven could you please publish your latest spec file + patches (if needed) so i
> can take a closer look? sorry for the delays, but i have been rather busy.
I'm working on the dependencies, but I'm also as you are, a bit busy ;).
Since the review ticket for a dependency was closed due to inactivity, I'll close this as well.