Bug 754724 - Shouldn't be able to click "Promote" button if Changeset is already in process of being promoted
Summary: Shouldn't be able to click "Promote" button if Changeset is already in proces...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: 6.0.1
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: Unspecified
Assignee: Eric Helms
QA Contact: Katello QA List
URL:
Whiteboard:
Depends On:
Blocks: katello-blockers
TreeView+ depends on / blocked
 
Reported: 2011-11-17 15:01 UTC by Corey Welton
Modified: 2019-09-26 13:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-22 18:07:24 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Corey Welton 2011-11-17 15:01:07 UTC
Description of problem:
If a changeset is in the middle of being promoted, user can click through the "Promoting..." text/link to view the changeset and click the "Promote" button again.  If something is in the process of being promoted, it makes sense that the button shouldn't be enabled for continued attempts until this one passes/fails

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.  Sync RH content
2.  Create a new changeset, "Test Changeset"
3.  Add content to the changeset; review and Promote content
4.  On resulting UI, note "Promoting... Test Changeset"; click this text to view the Changeset details
5. Observe menu bar at bottom; click "Promote"
  
Actual results:
Button is clickable

Expected results:
Probably should not be clickable if it is already in process.

Additional info:

I am not sure if this can trigger a race condition or not - unsure whether there are safeguards in place to prevent - but it seems it shouldn't be enabled in the first place.

Comment 1 Eric Helms 2012-01-24 16:05:32 UTC
6532dc83589dd5a4c6f3b308d12abf30ed4d80d7

Now when viewing the details of a promoting changeset all action buttons are disabled.

Comment 2 Mike McCune 2012-01-26 19:07:58 UTC
mass ON_QA move

Comment 4 Corey Welton 2012-02-01 04:22:08 UTC
QA Verified.

Comment 6 Mike McCune 2013-08-16 17:53:35 UTC
getting rid of 6.0.0 version since that doesn't exist


Note You need to log in before you can comment on or make changes to this bug.