Bug 755225 - Applet claims my CPU is frozen
Summary: Applet claims my CPU is frozen
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-shell-extension-cpu-temperature
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabian Affolter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-19 18:42 UTC by Sam Varshavchik
Modified: 2012-03-06 20:32 UTC (History)
2 users (show)

Fixed In Version: gnome-shell-extension-cpu-temperature-0-0.4.gite1777e6.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-06 19:22:17 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Typo fix (813 bytes, patch)
2011-12-10 03:32 UTC, Sam Varshavchik
no flags Details | Diff
Full output from sensors, and "sensors -u" (2.17 KB, text/plain)
2011-12-10 16:06 UTC, Sam Varshavchik
no flags Details
Full output from sensors, and "sensors -u" (5.16 KB, text/plain)
2011-12-10 16:12 UTC, Sam Varshavchik
no flags Details

Description Sam Varshavchik 2011-11-19 18:42:31 UTC
Description of problem:

After upgrading from F15 to F16, the applet shows that my CPU temperature is at the freezing point of water.

Version-Release number of selected component (if applicable):

gnome-shell-extension-cpu-temperature-0-0.3.git1f471c7.fc16.src.rpm

How reproducible:

Always

The applet is likely picking a false reading from sensors:

[root@monster ~]# sensors
nouveau-pci-0600
Adapter: PCI adapter
temp1:         +0.0°C  (high = +100.0°C, crit = +110.0°C)

coretemp-isa-0000
Adapter: ISA adapter
Core 0:       +34.0°C  (high = +87.0°C, crit = +97.0°C)
Core 1:       +32.0°C  (high = +87.0°C, crit = +97.0°C)
Core 2:       +35.0°C  (high = +87.0°C, crit = +97.0°C)
Core 3:       +29.0°C  (high = +87.0°C, crit = +97.0°C)

coretemp-isa-0001
Adapter: ISA adapter
Core 0:       +31.0°C  (high = +87.0°C, crit = +97.0°C)
Core 1:       +30.0°C  (high = +87.0°C, crit = +97.0°C)
Core 2:       +32.0°C  (high = +87.0°C, crit = +97.0°C)
Core 3:       +26.0°C  (high = +87.0°C, crit = +97.0°C)


The applet appears to be showing that false reading of 0C, and ignores all the eight real temperature sensors from my actual CPU cores.

Even if I suppress manually suppress that false sensors, in sensors.conf, so that "sensors" no longer shows it, the applet still picks it up.

Comment 1 Fabian Affolter 2011-11-19 21:15:39 UTC
Can you please report that bug upstream?

https://github.com/RaphaelKimmig/Gnome-Presentation-Mode

Comment 2 Dipesh Acharya 2011-12-08 19:18:57 UTC
The upstream URL is bot correct.

The extension has been updated at https://github.com/xtranophilist/gnome-shell-extension-cpu-temperature

Please verify if the latest version works and report back.

Comment 3 Sam Varshavchik 2011-12-08 23:09:05 UTC
Pulled the latest version. Works better, but it's showing only four out of the eight available temperature sensors.

Peeking at the code, its using the sensor label as a key for an associative array. This version is getting confused because sensors is reporting "Core 0" through "Core 3" temperature, for the first CPU, and "Core 0" through "Core 3" temperature for the second CPU. It's getting confused by multiple sensors with the same name.

See above for an example.

Comment 4 Fabian Affolter 2011-12-08 23:27:28 UTC
Sorry, the URL was wrong https://github.com/xtranophilist/gnome-shell-extension-cpu-temperature/issues

If you provide a patch I can add that patch to the package as long that upstream didn't fix it.

Comment 5 Sam Varshavchik 2011-12-09 02:43:34 UTC
There are a number of other issues with the current version. It expects that all temperature sensor labels are five characters in length, etc...

The names of temperature sensors are exclusively set in /etc/sensors3.conf, and can be anything, and not always five characters in length; and may not necessarily be named "Core X".

Generally, Fedora packages for minor software of this kind tends to avoid extensive patching, and stay closer to upstream. It's better to wait until it's fixed upstream.

Comment 6 Dipesh Acharya 2011-12-09 18:51:43 UTC
Updated the code again. The extension should show all different sensors now.

Yes, this extension supposes the strings on sensors3.conf aren't modified. It would be a better idea to read the sensors.conf file first and then look for the pattern accordingly in the sensors output. This is very much in the priority list for future along with user preferences and other things.

Thank you.

Comment 7 Sam Varshavchik 2011-12-10 03:32:36 UTC
Created attachment 544827 [details]
Typo fix

This version doesn't work at all, because of this typo.

After fixing this typo, it works. There are two lines in the applet's dropdown for each temperature reading. First one reads "ISA Adapter #:", and the next line has the temperature reading formatted as "CoreN: xxC". It's showing all eight core temperature readings, but I think that combining both lines for each temperature sensor, into a single "ISA Adapter #: CoreN xxC" line would've looked less confusing.

Comment 8 Dipesh Acharya 2011-12-10 05:11:47 UTC
Fixed the typo and the temperature is shown how the sensors gives.

Core Temperatures from the same ISA adapter are grouped together like:
ISA Adapter N:
Core0 : xxC
Core1 : yyC
Core2 : zzC
...

Thanks for reporting.

Comment 9 Sam Varshavchik 2011-12-10 16:06:48 UTC
Created attachment 544904 [details]
Full output from sensors, and "sensors -u"

Yes, that's much clearer.

This fix is probably the best one, at this time, but over the long term, it will be better to work with lm_sensors owners to add an option to sensors that would

Comment 10 Sam Varshavchik 2011-12-10 16:12:37 UTC
Created attachment 544907 [details]
Full output from sensors, and "sensors -u"

ehh.. accidentally submitted the comment too soon. Continuing with the last comment, anyway, have you considered running "sensors -u" instead of "sensors". The output seems to be much easier to parse.

Here's what the full output from "sensors" and "sensors -u" shows for me. In addition to the 8 CPU core temperatures, looks like my hardware has at least eight additional temperature sensors on the motherboard, of which three are disables, and of the remaining five enabled sensors, two have garbage, but I still have three other miscellaneous temperature sensors that appear to work.

But this version looks reasonable to me, anyway.

Comment 11 Dipesh Acharya 2011-12-16 01:16:02 UTC
This bug should be marked as resolved/fixed.

Comment 12 Fedora Update System 2012-02-25 19:07:06 UTC
gnome-shell-extension-cpu-temperature-0-0.4.gite1777e6.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/gnome-shell-extension-cpu-temperature-0-0.4.gite1777e6.fc16

Comment 13 Fedora Update System 2012-02-25 19:07:23 UTC
gnome-shell-extension-cpu-temperature-0-0.4.gite1777e6.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gnome-shell-extension-cpu-temperature-0-0.4.gite1777e6.fc17

Comment 14 Fedora Update System 2012-02-26 00:23:13 UTC
Package gnome-shell-extension-cpu-temperature-0-0.4.gite1777e6.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gnome-shell-extension-cpu-temperature-0-0.4.gite1777e6.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-2451/gnome-shell-extension-cpu-temperature-0-0.4.gite1777e6.fc16
then log in and leave karma (feedback).

Comment 15 Fedora Update System 2012-03-06 19:22:17 UTC
gnome-shell-extension-cpu-temperature-0-0.4.gite1777e6.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2012-03-06 20:32:14 UTC
gnome-shell-extension-cpu-temperature-0-0.4.gite1777e6.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.