Bug 755275 - Review Request: csslint - Detecting potential problems in CSS code
Summary: Review Request: csslint - Detecting potential problems in CSS code
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-20 09:46 UTC by Guillaume Kulakowski
Modified: 2014-09-02 12:34 UTC (History)
3 users (show)

Fixed In Version: csslint-0.9.2-2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-25 18:52:42 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Guillaume Kulakowski 2011-11-20 09:46:21 UTC
Spec URL:
https://projects.llaumgui.com/p/rpmbuild/source/tree/master/SPECS/csslint.spec
f
SRPM URL:
http://llaumgui.fedorapeople.org/review/csslint/csslint-0.8.1-1.fc16.noarch.rpm

Project URL: https://github.com/stubbornella/csslint

Description:
CSSLint is a tool to help point out problems with your CSS code. It does basic syntax checking as well as applying a set of rules to the code that look for problematic patterns or signs of inefficiency. The rules are all pluggable, so you can easily write your own or omit ones you don't want.

rpmlint output:
builder@enterprise ~> rpmlint rpmbuild/**/*.rpm               
csslint.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged
csslint.noarch: W: no-manual-page-for-binary csslint
csslint.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged
csslint.src: W: strange-permission csslint.sh 0755L
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Comment 1 Parag AN(पराग) 2011-11-21 04:11:24 UTC
Provide a valid SRPM URL

Comment 2 Guillaume Kulakowski 2011-11-21 06:46:57 UTC
SRPM URL:
http://llaumgui.fedorapeople.org/review/csslint/csslint-0.8.1-1.fc16.src.rpm

Comment 3 Parag AN(पराग) 2011-11-22 11:47:56 UTC
eview:

+ koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3529016

+ rpmlint on rpms gave
csslint.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged
csslint.src: W: strange-permission csslint.sh 0755L
csslint.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged
csslint.noarch: W: no-manual-page-for-binary csslint
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ source match with upstream as (sha1sum)
d6314b6253922032d8e3c4520b446a9f20ea6578  master
d6314b6253922032d8e3c4520b446a9f20ea6578  ../SOURCES/stubbornella-csslint-v0.8.1-13-g2ec2ebb.tar.gz


Suggestions:
1) If building this on Fedora only then you don't need
  a) buildroot
  b) %clean section
  c) defattr(-,root,root,-)

2) I see newer commits are already in upstream. Try to ask upstream to either release a tarball or create a tag for 0.8.5

also if you are packaging snapshots then see  http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

Comment 4 Parag AN(पराग) 2011-12-21 10:11:45 UTC
any updates here?

Comment 5 Guillaume Kulakowski 2011-12-23 11:37:19 UTC
Hi,

1) If building this on Fedora only then you don't need [...]
I package also for EPEL.

2) This is a new build from 0.8.5 tag


Spec URL:
https://projects.llaumgui.com/p/rpmbuild/source/tree/master/SPECS/csslint.spec

SRPM URL:
http://llaumgui.fedorapeople.org/review/csslint/csslint-0.8.5-1.fc16.src.rpm

Comment 6 Parag AN(पराग) 2011-12-29 08:30:46 UTC
+ koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3608918

+ rpmlint on rpms gave
csslint.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged
csslint.src: W: strange-permission csslint.sh 0755L
csslint.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged
csslint.noarch: W: no-manual-page-for-binary csslint
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ source verified as 
b7ce5887073a08c4c6a08022ef43c2126737e0f7  v0.8.5
b7ce5887073a08c4c6a08022ef43c2126737e0f7  ../SOURCES/stubbornella-csslint-v0.8.5-0-g0394212.tar.gz

APPROVED.

Comment 7 Guillaume Kulakowski 2012-01-03 06:39:19 UTC
New Package SCM Request
=======================
Package Name: csslint
Short Description: Detecting potential problems in CSS code
Owners:
Branches: f15 f16 el5 el6
InitialCC:

Comment 8 Gwyn Ciesla 2012-01-03 13:26:58 UTC
No valid FAS accounts listed, summary name and SCM request names don't
match.

Comment 9 Guillaume Kulakowski 2012-01-04 06:54:18 UTC
New Package SCM Request
=======================
Package Name: csslint
Short Description: Detecting potential problems in CSS code
Owners: llaumgui
Branches: f15 f16 el5 el6
InitialCC:

Comment 10 Gwyn Ciesla 2012-01-04 13:39:26 UTC
Summary and SCM pacakge names don't match, please rectify.

Comment 11 Guillaume Kulakowski 2012-01-04 19:39:21 UTC
Summary is "Review Request: csslint - Detecting potential problems in CSS code" -> "Review Request: <Package Name> - <Short Description>". Where is the problem ?

Comment 12 Guillaume Kulakowski 2012-01-04 19:42:18 UTC
OK: CSSLINT != csslint. Thanks parag for fix this: https://bugzilla.redhat.com/show_activity.cgi?id=755275

Comment 13 Gwyn Ciesla 2012-01-04 19:57:31 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2012-01-08 11:16:45 UTC
csslint-0.9.2-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/csslint-0.9.2-1.fc16

Comment 15 Fedora Update System 2012-01-08 11:18:02 UTC
csslint-0.9.2-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/csslint-0.9.2-1.fc15

Comment 16 Fedora Update System 2012-01-08 11:19:25 UTC
csslint-0.9.2-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/csslint-0.9.2-1.el5

Comment 17 Fedora Update System 2012-01-08 11:19:26 UTC
csslint-0.9.2-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/csslint-0.9.2-1.el6

Comment 18 Fedora Update System 2012-01-08 13:04:08 UTC
csslint-0.9.2-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/csslint-0.9.2-2.fc16

Comment 19 Fedora Update System 2012-01-08 13:06:08 UTC
csslint-0.9.2-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/csslint-0.9.2-2.el5

Comment 20 Fedora Update System 2012-01-08 13:06:42 UTC
csslint-0.9.2-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/csslint-0.9.2-2.fc15

Comment 21 Fedora Update System 2012-01-08 13:07:08 UTC
csslint-0.9.2-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/csslint-0.9.2-2.el6

Comment 22 Fedora Update System 2012-01-11 05:57:45 UTC
csslint-0.9.2-2.fc15 has been pushed to the Fedora 15 testing repository.

Comment 23 Fedora Update System 2012-01-25 18:52:42 UTC
csslint-0.9.2-2.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 24 Fedora Update System 2012-01-25 18:53:20 UTC
csslint-0.9.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 25 Fedora Update System 2012-01-25 22:26:13 UTC
csslint-0.9.2-2.fc16 has been pushed to the Fedora 16 stable repository.

Comment 26 Fedora Update System 2012-01-25 22:34:29 UTC
csslint-0.9.2-2.fc15 has been pushed to the Fedora 15 stable repository.

Comment 27 Guillaume Kulakowski 2014-09-01 13:27:12 UTC
Package Change Request
======================
Package Name: csslint
New Branches: EL-7
Owners: llaumgui

Comment 28 Gwyn Ciesla 2014-09-02 12:34:35 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.