Hide Forgot
Spec URL: http://tradej.fedorapeople.org/maven-toolchains-plugin/1.0/1/maven-toolchains-plugin.spec SRPM URL: http://tradej.fedorapeople.org/maven-toolchains-plugin/1.0/1/maven-toolchains-plugin-1.0-1.fc15.src.rpm Description: The Toolchains Plugins allows to share configuration across plugins. For example to make sure the plugins like compiler, surefire, javadoc, webstart etc. all use the same JDK for execution. Similarly to maven-enforcer-plugin, it allows to control environmental constraints in the build.
Please use the upstream tarball http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-toolchains-plugin/1.0/maven-toolchains-plugin-1.0-source-release.zip
Also the jars/poms should not be in maven subdir. That's just for maven itself. Plugins extensions should be in main javadir (or their own subdir)
Fixed. Spec URL: http://tradej.fedorapeople.org/maven-toolchains-plugin/1.0/2/maven-toolchains-plugin.spec SRPM URL: http://tradej.fedorapeople.org/maven-toolchains-plugin/1.0/2/maven-toolchains-plugin-1.0-2.fc15.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3532242
Oh, sorry, wrong Koji build. This is it: http://koji.fedoraproject.org/koji/taskinfo?taskID=3532301
I'll take it.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [X] Rpmlint output: rpmlint ./maven-toolchains-plugin.spec ./maven-toolchains-plugin.spec: W: invalid-url Source0: http://repo1.org/maven2/org/apache/plugins/maven-toolchains-plugin/1.0/maven-toolchains-plugin-1.0-source-release.zip <urlopen error [Errno -2] Name or service not known> 0 packages and 1 specfiles checked; 0 errors, 1 warnings. rpmlint ./maven-toolchains-plugin-1.0-2.fc15.src.rpm maven-toolchains-plugin.src: I: enchant-dictionary-not-found en_US maven-toolchains-plugin.src: W: invalid-url Source0: http://repo1.org/maven2/org/apache/plugins/maven-toolchains-plugin/1.0/maven-toolchains-plugin-1.0-source-release.zip <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 1 warnings. See issue #1. [X] Package is named according to the Package Naming Guidelines[1]. [X] Spec file name must match the base package name, in the format %{name}.spec. [X] Package meets the Packaging Guidelines[2]. [X] Package successfully compiles and builds into binary rpms. [X] Buildroot definition is not present [X] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [X] License field in the package spec file matches the actual license. License type: ASL 2.0 [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-] All independent sub-packages have license of their own [X] Spec file is legible and written in American English. [X] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 05cd615acfd2acfa8c8bd29447ab7ec6 MD5SUM upstream package: 05cd615acfd2acfa8c8bd29447ab7ec6 [X] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [X] Package must own all directories that it creates or must require other packages for directories it uses. [X] Package does not contain duplicates in %files. [X] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [X] Permissions on files are set properly. [X] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [X] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [X] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [X] Package does not own files or directories owned by other packages. [X] Javadoc documentation files are generated and included in -javadoc subpackage [X] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [X] Packages have proper BuildRequires/Requires on jpackage-utils [X] Javadoc subpackages have Require: jpackage-utils [X] Package uses %global not %define [-] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [X] If source tarball includes bundled jar/class files these need to be removed prior to building [X] All filenames in rpm packages must be valid UTF-8. [X] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [-] If package contains pom.xml files install it (including depmaps) even when building with ant [X] pom files has correct add_maven_depmap === Maven === [X] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment [X] Package DOES NOT use %update_maven_depmap in %post/%postun [X] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro === Other suggestions === [X] If possible use upstream build method (maven/ant/javac) [X] Avoid having BuildRequires on exact NVR unless necessary [X] Package has BuildArch: noarch (if possible) [X] Latest version is packaged. [X] Reviewer should test that the package builds in mock. Tested on: https://koji.fedoraproject.org/koji/taskinfo?taskID=3622634 === Issues === 1. URL to source is wrong: Is: http://repo1.org/maven2/org/apache/plugins/maven-toolchains-plugin/1.0/maven-toolchains-plugin-1.0-source-release.zip Should be: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-toolchains-plugin/1.0/maven-toolchains-plugin-1.0-source-release.zip Please fix the link while importing the package, approving. ================ *** APPROVED *** ================
Okay, thank you. Can I have a repo, please? New Package SCM Request ======================= Package Name: maven-toolchains-plugin Short Description: Maven plugin for sharing configuration across projects Owners: tradej Branches: InitialCC: java-sig
Git done (by process-git-requests).
Thank you. Package's in, closing.