Bug 755775 - systemd does not honor settings in /etc/sysconfig/yppasswdd
Summary: systemd does not honor settings in /etc/sysconfig/yppasswdd
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ypserv
Version: 16
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Honza Horak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 833493
TreeView+ depends on / blocked
 
Reported: 2011-11-22 02:23 UTC by Ralf Corsepius
Modified: 2012-06-21 13:31 UTC (History)
3 users (show)

Fixed In Version: ypserv-2.26-8.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-10 19:45:24 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
wrapper script that uses the variables (929 bytes, text/plain)
2011-11-25 14:53 UTC, Honza Horak
no flags Details

Description Ralf Corsepius 2011-11-22 02:23:36 UTC
Description of problem:

With systemd, all settings from /etc/sysconfig/yppasswdd but YPPASSWDD_ARGS are being ignored.

Version-Release number of selected component (if applicable):
ypserv-2.26-2.fc16.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Edit /etc/sysconfig/yppasswdd to activate
PASSWDFILE, SHADOWFILE or ETCDIR.

2. run
 systemctl start yppasswdd.service
3. run
ps aux | grep yppasswd

  
Actual results:
PASSWDFILE, SHADOWFILE or ETCDIR are not being honored.

The only configuration option being honored is YPPASSWDD_ARGS.


Expected results:
These settings being honored

Additional info:
In my understanding, with sysv-init, /etc/sysconfig/* files were treated as shell script fragments, As such they were subject to shell-expansion/shell-quoting/shell-inclusion etc. 

Apparently this doesn't apply to systemd.

Comment 1 Honza Horak 2011-11-25 14:53:18 UTC
Created attachment 536349 [details]
wrapper script that uses the variables

Since systemd doesn't have any logic to be able to use the binary's arguments only if the environment variable is not empty, we need to create a wrapper script that does the work. The script will be then used in the unit file instead of rpc.yppasswdd itself.

The fix has been already applied in Rawhide and I'm going to add this script into F16 soon.

Comment 2 Fedora Update System 2011-11-28 09:53:28 UTC
ypserv-2.26-7.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/ypserv-2.26-7.fc16

Comment 3 Fedora Update System 2011-11-28 11:47:40 UTC
ypserv-2.26-8.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/ypserv-2.26-8.fc16

Comment 4 Fedora Update System 2011-11-29 00:08:20 UTC
Package ypserv-2.26-8.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ypserv-2.26-8.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2011-16503/ypserv-2.26-8.fc16
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2011-12-10 19:45:24 UTC
ypserv-2.26-8.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.